Skip to content

Commit 3ad3fce

Browse files
authored
Merge pull request #150 from cairoshell/fix-searchhelper-leak
Fix leak when referencing SearchHelper.Results
2 parents d040729 + dc4f4cb commit 3ad3fce

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/ManagedShell.Common/Helpers/SearchHelper.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ public class SearchHelper : DependencyObject
2525
static SearchHelper()
2626
{
2727
m_results = new ThreadSafeObservableCollection<SearchResult>();
28+
m_resultsReadOnly = new ReadOnlyObservableCollection<SearchResult>(m_results);
2829
}
2930

3031
public static readonly DependencyProperty SearchTextProperty = DependencyProperty.Register("SearchText",
@@ -193,10 +194,11 @@ public string SearchText
193194
}
194195

195196
static ThreadSafeObservableCollection<SearchResult> m_results;
197+
static ReadOnlyObservableCollection<SearchResult> m_resultsReadOnly;
196198

197199
public ReadOnlyObservableCollection<SearchResult> Results
198200
{
199-
get { return new ReadOnlyObservableCollection<SearchResult>(m_results); }
201+
get { return m_resultsReadOnly; }
200202
}
201203
}
202204
}

0 commit comments

Comments
 (0)