Merge pull request #144 from cairoshell/fix-storyboard-leak

Fix leak from autohide storyboard

Author: josuave

src/ManagedShell.AppBar/AppBarWindow.cs

@@ -92,6 +92,7 @@ public FrameworkElement AutoHideElement
             set
             {
                 _autoHideElement = value;
+                _autoHideElement.RenderTransform = new TranslateTransform();
                 OnPropertyChanged();
             }
         }
@@ -225,24 +226,18 @@ private void AnimateAutoHide(bool isHiding, bool immediate = false)
             animation.BeginTime = TimeSpan.FromMilliseconds(immediate ? 0 : isHiding ? AutoHideDelayMs : AutoHideShowDelayMs);
             animation.EasingFunction = new SineEase();
 
-            Storyboard.SetTarget(animation, AutoHideElement);
-            Storyboard.SetTargetProperty(animation, new PropertyPath($"RenderTransform.(TranslateTransform.{(Orientation == Orientation.Horizontal ? 'Y' : 'X')})"));
-
-            var storyboard = new Storyboard();
-            storyboard.Children.Add(animation);
-
             animation.CurrentStateInvalidated += (object sender, EventArgs e) => {
                 if (((AnimationClock)sender).CurrentState == ClockState.Active)
                 {
                     OnAutoHideAnimationBegin(isHiding);
                 }
             };
 
-            storyboard.Completed += (object sender, EventArgs e) => {
+            animation.Completed += (object sender, EventArgs e) => {
                 OnAutoHideAnimationComplete(isHiding);
             };
 
-            storyboard.Begin(AutoHideElement);
+            AutoHideElement.RenderTransform.BeginAnimation(Orientation == Orientation.Horizontal ? TranslateTransform.YProperty : TranslateTransform.XProperty, animation);
         }
 
         protected void PeekDuringAutoHide(int msToPeek = 1000)
@@ -368,6 +363,8 @@ private void OnClosing(object sender, CancelEventArgs e)
             {
                 UnregisterAppBar();
                 _appBarManager.UnregisterAutoHideBar(this);
+                AutoHideElement?.RenderTransform?.BeginAnimation(TranslateTransform.YProperty, null);
+                AutoHideElement?.RenderTransform?.BeginAnimation(TranslateTransform.XProperty, null);
 
                 // unregister full-screen notifications
                 _fullScreenHelper.FullScreenApps.CollectionChanged -= FullScreenApps_CollectionChanged;