From b20466c29d56c0caa189afa16aaab9747d2711ff Mon Sep 17 00:00:00 2001 From: Benjamin Drung Date: Tue, 21 Apr 2026 13:38:09 +0200 Subject: [PATCH] test: avoid strip() on problem report Order key The value for the `Order` key is of type `ProblemReportValue` which might not have the `strip()` method. So avoid calling `strip()` to make the test more robust and allow adding more type hints to `ProblemReport`. --- tests/integration/test_report.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/integration/test_report.py b/tests/integration/test_report.py index 95f9014ed..14e6f1c84 100644 --- a/tests/integration/test_report.py +++ b/tests/integration/test_report.py @@ -1324,7 +1324,7 @@ def add_info(report): self.assertEqual(r["CommonField1"], "CommonField 1") self.assertEqual(r["CommonField2"], "CommonField 2") self.assertEqual(r["CommonField3"], "NoninteractiveHookUI()") - self.assertEqual(r["Order"].strip(), "foo1 foo2 foo3 foo") + self.assertEqual(r["Order"], " foo1 foo2 foo3 foo") r = apport.report.Report() r["Package"] = "foo 4.5-6" @@ -1350,7 +1350,7 @@ def add_info(report): self.assertEqual(r["Field2"], "Field 2\nBla") self.assertEqual(r["CommonField1"], "CommonField 1") self.assertEqual(r["CommonField2"], "CommonField 2") - self.assertEqual(r["Order"].strip(), "foo1 foo2 foo3 foo") + self.assertEqual(r["Order"], " foo1 foo2 foo3 foo") # test hook abort r["Spethial"] = "1" @@ -1400,7 +1400,7 @@ def add_info(report, ui): self.assertEqual(r["CommonField1"], "CommonField 1") self.assertEqual(r["CommonField2"], "CommonField 2") self.assertEqual(r["CommonField3"], "NoninteractiveHookUI()") - self.assertEqual(r["Order"].strip(), "foo1 foo2 foo3 source_foo") + self.assertEqual(r["Order"], " foo1 foo2 foo3 source_foo") # test hook abort r["Package"] = "spethial"