From d539c1fce680eb292d650e21d484a572fc10a73d Mon Sep 17 00:00:00 2001 From: Ani Sinha Date: Wed, 1 Apr 2026 18:22:47 +0530 Subject: [PATCH] test: fix test_get_domainname_isc_dhclient mock leak Without mocking out dhcp.IscDhclient.get_newest_lease_file_from_distro, the functions on some platforms returns None. This means get_key_from_latest_lease() bails out early without calling parse_leases() to parse the lease file. Fix it. Signed-off-by: Ani Sinha --- tests/unittests/sources/test_cloudstack.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/unittests/sources/test_cloudstack.py b/tests/unittests/sources/test_cloudstack.py index f276f274e64..9e524cd2e95 100644 --- a/tests/unittests/sources/test_cloudstack.py +++ b/tests/unittests/sources/test_cloudstack.py @@ -108,6 +108,10 @@ def test_get_domainname_isc_dhclient(self, cloudstack_ds, mocker): DHCP_MOD_PATH + ".networkd_get_option_from_leases", get_networkd_domain, ) + mocker.patch( + MOD_PATH + ".dhcp.IscDhclient.get_newest_lease_file_from_distro", + return_value=True, + ) with patch( MOD_PATH + ".util.load_text_file",