Skip to content

Remove older Juju compatibility code #253

@dimaqq

Description

@dimaqq

Specifically:

try:
self._secret_content = self.meta.get_content(refresh=True)
except (ValueError, ModelError) as err:
# https://bugs.launchpad.net/juju/+bug/2042596
# Only triggered when 'refresh' is set
if isinstance(err, ModelError) and not any(
msg in str(err) for msg in self.KNOWN_MODEL_ERRORS
):
raise
# Due to: ValueError: Secret owner cannot use refresh=True
self._secret_content = self.meta.get_content()

I believe this has been fixed already:
https://bugs.launchpad.net/juju/+bug/2042596
https://bugs.launchpad.net/juju/+bug/2037120

In which case, the only affected Juju versions were 3.0.x and older 3.1.x;
Now that those minor versions are EOL, the work-around can be removed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions