Skip to content

requests.get() calls should use a timeout #40

@ca-scribner

Description

@ca-scribner

_get_schema_response_from_remote() makes requests.get() calls, but we've found that when they do not have connectivity (no internet, incorrect proxy settings, etc) these requests hang indefinitely. This is because they by default do not have a timeout as is suggested by requests. This makes it hard to debug as, rather than seeing a failure due to connectivity, users just see a charm stuck in a hook execution.

Recommended that we set a timeout here, maybe in the order of 10s?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status

    Labeled

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions