Skip to content

Fix the oscilloscope having the incorrect polarity #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the oscilloscope having the incorrect polarity #1331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/webamp/js/components/VisPainter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,13 @@
// y is then adjusted downward to be in the center of the scope
y = Math.round((y / 16) * 2) - 9;

// this sucks
// the way i'm getting the data in the first place makes it difficult to properly re-massage
// if getByteTimeDomainData was perfectly at 0 and we had to deal with signed/unsigned conversion
// i wouldn't have to do this...
// note to self: rejig this with getFloatTimeDomainData later
y = -y+14;

Check failure on line 681 in packages/webamp/js/components/VisPainter.ts

View workflow job for this annotation

GitHub Actions / ci 

Replace `+` with `·+·`

// adjusts the center point of y if we are in windowShade mode, and if pixelDensity is 2
// where it's adjusted further to give you the fullest view possible in that small window
// else we leave y as is
Expand Down
Loading