-
-
Notifications
You must be signed in to change notification settings - Fork 69
FR: allow target-arch
of arm64
in addition of aarch64
in archive names
#2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am a bit reluctant to add more of that, the resolution is already quite slow now (and even need github access token to speedup). I think maybe changing the Or, we could add simple ternary operator |
Overall, I'm not sure what's best, but here are some thoughts.
This would also need to apply to Windows-ARM and Linux-ARM, so it'd be three overrides.
I think "arm64" might be common enough to make it worth it. I am worried about this a bit in the context of #2119 though (I guess specifying the pkg-fmt could be required in that case).
Another option that comes to mind is allowing one to specify [package.metadata.binstall.definitions]
my-target-arch.source = "target-arch"
my-target-arch.mapping = { aarch64 = "arm64" } |
I think maybe we can have an
This also sounds good, cc @passcod wdyt? |
Oh, as a generalised template variable definition/mapping? That sounds good yeah. |
I'm having trouble setting up binstall for https://github.com/drdo/redu/releases because
their archives for ARM systems end with
redu-0.2.12-darwin-arm64.bz2
whilebinstall
expectsredu-0.2.12-darwin-aarch64.bz2
. The{ target-arch }
I might be able to convince them to rename the archive, but still, it would be nice if
binstall
tried that automatically. Even internally,binstall
often calls the architecturearm64
.I think I could work around this by setting up
[package.metadata.binstall.overrides.XXXXXX]
for each arm64 binary, but that seems annoying (though maybe).A fancier, and not necessarily better, solution would be to allow conditionals in templates in https://github.com/cargo-bins/cargo-binstall/blob/main/SUPPORT.md
The text was updated successfully, but these errors were encountered: