Skip to content

need return statements in _find_neighbor() & _update_point() #69

@jGaboardi

Description

@jGaboardi
  • Came across this while working on add type hints #55
  • Do does there actually need to be return statements in _find_neighbor()1 and _update_point()2? The values are being set to the data structure itself, and there appears to be nothing being return in the current functional codebase.
  • The unknown here is the currently commented out merge_closest()3 method that may in fact need to return a value
  • xref:

cc @gegen07

Footnotes

  1. https://github.com/carsonfarmer/fastpair/blob/d2b38aad4597ec5d2572a9b5d2abbd60905e92fe/fastpair/base.py#L226

  2. https://github.com/carsonfarmer/fastpair/blob/d2b38aad4597ec5d2572a9b5d2abbd60905e92fe/fastpair/base.py#L259

  3. https://github.com/carsonfarmer/fastpair/blob/d2b38aad4597ec5d2572a9b5d2abbd60905e92fe/fastpair/base.py#L265

Metadata

Metadata

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions