-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
Description
- Came across this while working on add type hints #55
- Do does there actually need to be
returnstatements in_find_neighbor()1 and_update_point()2? The values are being set to the data structure itself, and there appears to be nothing being return in the current functional codebase. - The unknown here is the currently commented out
merge_closest()3 method that may in fact need to return a value - xref:
cc @gegen07
Footnotes
-
https://github.com/carsonfarmer/fastpair/blob/d2b38aad4597ec5d2572a9b5d2abbd60905e92fe/fastpair/base.py#L226 ↩
-
https://github.com/carsonfarmer/fastpair/blob/d2b38aad4597ec5d2572a9b5d2abbd60905e92fe/fastpair/base.py#L259 ↩
-
https://github.com/carsonfarmer/fastpair/blob/d2b38aad4597ec5d2572a9b5d2abbd60905e92fe/fastpair/base.py#L265 ↩
gegen07