From ad8e1abce91f079cea64ab1a0edbb06bda48cd8c Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Wed, 3 Sep 2025 15:36:13 +0000 Subject: [PATCH 01/11] Add data and updated sorting --- R/formulas.R | 3 +- tests/testthat/data/mki_ki_data.csv | 64 +++++++++++++++-------------- 2 files changed, 35 insertions(+), 32 deletions(-) diff --git a/R/formulas.R b/R/formulas.R index 9c6f734..4cc6f35 100644 --- a/R/formulas.R +++ b/R/formulas.R @@ -178,7 +178,8 @@ prb <- function(assessed, sale_price, na.rm = FALSE) { # Calculate the Gini cofficients needed for KI and MKI calc_gini <- function(assessed, sale_price) { df <- data.frame(av = assessed, sp = sale_price) - df <- df[order(df$sp), ] + df <- df %>% + arrange(sp, desc(av)) assessed_price <- df$av sale_price <- df$sp n <- length(assessed_price) diff --git a/tests/testthat/data/mki_ki_data.csv b/tests/testthat/data/mki_ki_data.csv index dc99e5e..fa37aaa 100644 --- a/tests/testthat/data/mki_ki_data.csv +++ b/tests/testthat/data/mki_ki_data.csv @@ -1,31 +1,33 @@ -"","Sale_Price","Assessed" -"1",32900,37299 -"2",36000,40166 -"3",54000,56317 -"4",64500,66184 -"5",68000,69487 -"6",70000,71515 -"7",74000,75338 -"8",80000,81036 -"9",84900,85673 -"10",89000,85021 -"11",94250,90046 -"12",99000,94089 -"13",105900,100227 -"14",109000,103157 -"15",115000,108290 -"16",124500,117099 -"17",129900,115347 -"18",135000,119678 -"19",149000,131631 -"20",155800,137321 -"21",163500,143974 -"22",175000,153572 -"23",179000,148457 -"24",185600,153488 -"25",199900,165040 -"26",215000,176940 -"27",235000,192959 -"28",250000,180046 -"29",279000,200240 -"30",295000,211445 +"Sale_Price","Assessed","Assessed_1","Assessed_2" +32900,37299.37125,37299.37125,37299.37125 +36000,40165.89269,40165.89269,40165.89269 +54000,56317.4201,56317.4201,56317.4201 +64500,66183.77244,66183.77244,66183.77244 +68000,69486.97316,69486.97316,69486.97316 +70000,71514.52586,71514.52586,71514.52586 +74000,75338.28603,75338.28603,75338.28603 +80000,81035.95111,81035.95111,81035.95111 +84900,85672.85577,85672.85577,85672.85577 +89000,85021.0865,94088.93683,90046.33945 +89000,90046.33945,85021.0865,94088.93683 +89000,94088.93683,90046.33945,85021.0865 +105900,100227.0936,100227.0936,100227.0936 +109000,103156.7516,103156.7516,103156.7516 +115000,108290.1277,108290.1277,108290.1277 +124500,117098.7563,117098.7563,117098.7563 +129900,115346.9796,115346.9796,115346.9796 +135000,119678.4223,119678.4223,119678.4223 +149000,131630.9478,131630.9478,131630.9478 +155800,137321.2061,137321.2061,137321.2061 +163500,143973.5639,143973.5639,143973.5639 +175000,153571.8563,153571.8563,153571.8563 +179000,148456.8866,148456.8866,148456.8866 +185600,153488.3876,153488.3876,153488.3876 +199900,165039.8271,165039.8271,165039.8271 +215000,176939.5763,176939.5763,176939.5763 +235000,192959.3127,192959.3127,192959.3127 +250000,180046.1193,180046.1193,180046.1193 +279000,200240.2442,200240.2442,200240.2442 +295000,211445.4891,211445.4891,211445.4891 + + From da3a20756740c9a9669838ec423025162a089d00 Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Wed, 3 Sep 2025 15:43:51 +0000 Subject: [PATCH 02/11] remove dplyr --- R/formulas.R | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/R/formulas.R b/R/formulas.R index 4cc6f35..b78e134 100644 --- a/R/formulas.R +++ b/R/formulas.R @@ -178,8 +178,7 @@ prb <- function(assessed, sale_price, na.rm = FALSE) { # Calculate the Gini cofficients needed for KI and MKI calc_gini <- function(assessed, sale_price) { df <- data.frame(av = assessed, sp = sale_price) - df <- df %>% - arrange(sp, desc(av)) + df <- df[order(df$sp, -df$av), ] assessed_price <- df$av sale_price <- df$sp n <- length(assessed_price) From a2c39779436c2ee7b13dc9f64bfd8fef5de2812a Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Wed, 3 Sep 2025 15:55:15 +0000 Subject: [PATCH 03/11] lintr --- tests/testthat/data/mki_ki_data.csv | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/testthat/data/mki_ki_data.csv b/tests/testthat/data/mki_ki_data.csv index fa37aaa..9a35b27 100644 --- a/tests/testthat/data/mki_ki_data.csv +++ b/tests/testthat/data/mki_ki_data.csv @@ -29,5 +29,3 @@ 250000,180046.1193,180046.1193,180046.1193 279000,200240.2442,200240.2442,200240.2442 295000,211445.4891,211445.4891,211445.4891 - - From 58a10df22e100979fe8cf61288f16b9c10f5902c Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Wed, 3 Sep 2025 16:50:33 +0000 Subject: [PATCH 04/11] use two csv files --- tests/testthat/data/mki_ki_data.csv | 62 +++++++++---------- .../data/mki_ki_data_with_tiebreaks.csv | 31 ++++++++++ 2 files changed, 62 insertions(+), 31 deletions(-) create mode 100644 tests/testthat/data/mki_ki_data_with_tiebreaks.csv diff --git a/tests/testthat/data/mki_ki_data.csv b/tests/testthat/data/mki_ki_data.csv index 9a35b27..dc99e5e 100644 --- a/tests/testthat/data/mki_ki_data.csv +++ b/tests/testthat/data/mki_ki_data.csv @@ -1,31 +1,31 @@ -"Sale_Price","Assessed","Assessed_1","Assessed_2" -32900,37299.37125,37299.37125,37299.37125 -36000,40165.89269,40165.89269,40165.89269 -54000,56317.4201,56317.4201,56317.4201 -64500,66183.77244,66183.77244,66183.77244 -68000,69486.97316,69486.97316,69486.97316 -70000,71514.52586,71514.52586,71514.52586 -74000,75338.28603,75338.28603,75338.28603 -80000,81035.95111,81035.95111,81035.95111 -84900,85672.85577,85672.85577,85672.85577 -89000,85021.0865,94088.93683,90046.33945 -89000,90046.33945,85021.0865,94088.93683 -89000,94088.93683,90046.33945,85021.0865 -105900,100227.0936,100227.0936,100227.0936 -109000,103156.7516,103156.7516,103156.7516 -115000,108290.1277,108290.1277,108290.1277 -124500,117098.7563,117098.7563,117098.7563 -129900,115346.9796,115346.9796,115346.9796 -135000,119678.4223,119678.4223,119678.4223 -149000,131630.9478,131630.9478,131630.9478 -155800,137321.2061,137321.2061,137321.2061 -163500,143973.5639,143973.5639,143973.5639 -175000,153571.8563,153571.8563,153571.8563 -179000,148456.8866,148456.8866,148456.8866 -185600,153488.3876,153488.3876,153488.3876 -199900,165039.8271,165039.8271,165039.8271 -215000,176939.5763,176939.5763,176939.5763 -235000,192959.3127,192959.3127,192959.3127 -250000,180046.1193,180046.1193,180046.1193 -279000,200240.2442,200240.2442,200240.2442 -295000,211445.4891,211445.4891,211445.4891 +"","Sale_Price","Assessed" +"1",32900,37299 +"2",36000,40166 +"3",54000,56317 +"4",64500,66184 +"5",68000,69487 +"6",70000,71515 +"7",74000,75338 +"8",80000,81036 +"9",84900,85673 +"10",89000,85021 +"11",94250,90046 +"12",99000,94089 +"13",105900,100227 +"14",109000,103157 +"15",115000,108290 +"16",124500,117099 +"17",129900,115347 +"18",135000,119678 +"19",149000,131631 +"20",155800,137321 +"21",163500,143974 +"22",175000,153572 +"23",179000,148457 +"24",185600,153488 +"25",199900,165040 +"26",215000,176940 +"27",235000,192959 +"28",250000,180046 +"29",279000,200240 +"30",295000,211445 diff --git a/tests/testthat/data/mki_ki_data_with_tiebreaks.csv b/tests/testthat/data/mki_ki_data_with_tiebreaks.csv new file mode 100644 index 0000000..bd5fb9d --- /dev/null +++ b/tests/testthat/data/mki_ki_data_with_tiebreaks.csv @@ -0,0 +1,31 @@ +"Sale_Price","Assessed","Assessed_alt_sort_1,Assessed_alt_sort_2" +32900,37299.37125,37299.37125,37299.37125 +36000,40165.89269,40165.89269,40165.89269 +54000,56317.4201,56317.4201,56317.4201 +64500,66183.77244,66183.77244,66183.77244 +68000,69486.97316,69486.97316,69486.97316 +70000,71514.52586,71514.52586,71514.52586 +74000,75338.28603,75338.28603,75338.28603 +80000,81035.95111,81035.95111,81035.95111 +84900,85672.85577,85672.85577,85672.85577 +89000,85021.0865,94088.93683,90046.33945 +89000,90046.33945,85021.0865,94088.93683 +89000,94088.93683,90046.33945,85021.0865 +105900,100227.0936,100227.0936,100227.0936 +109000,103156.7516,103156.7516,103156.7516 +115000,108290.1277,108290.1277,108290.1277 +124500,117098.7563,117098.7563,117098.7563 +129900,115346.9796,115346.9796,115346.9796 +135000,119678.4223,119678.4223,119678.4223 +149000,131630.9478,131630.9478,131630.9478 +155800,137321.2061,137321.2061,137321.2061 +163500,143973.5639,143973.5639,143973.5639 +175000,153571.8563,153571.8563,153571.8563 +179000,148456.8866,148456.8866,148456.8866 +185600,153488.3876,153488.3876,153488.3876 +199900,165039.8271,165039.8271,165039.8271 +215000,176939.5763,176939.5763,176939.5763 +235000,192959.3127,192959.3127,192959.3127 +250000,180046.1193,180046.1193,180046.1193 +279000,200240.2442,200240.2442,200240.2442 +295000,211445.4891,211445.4891,211445.4891 From 029741313d9b444b56de9e2c3ddf5421593ca286 Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Wed, 3 Sep 2025 19:34:20 +0000 Subject: [PATCH 05/11] correct " --- .../data/mki_ki_data_with_tiebreaks.csv | 2 +- tests/testthat/test-formulas.R | 66 ++++++++++++++++++- 2 files changed, 65 insertions(+), 3 deletions(-) diff --git a/tests/testthat/data/mki_ki_data_with_tiebreaks.csv b/tests/testthat/data/mki_ki_data_with_tiebreaks.csv index bd5fb9d..e68d75d 100644 --- a/tests/testthat/data/mki_ki_data_with_tiebreaks.csv +++ b/tests/testthat/data/mki_ki_data_with_tiebreaks.csv @@ -1,4 +1,4 @@ -"Sale_Price","Assessed","Assessed_alt_sort_1,Assessed_alt_sort_2" +"Sale_Price","Assessed","Assessed_alt_sort_1","Assessed_alt_sort_2" 32900,37299.37125,37299.37125,37299.37125 36000,40165.89269,40165.89269,40165.89269 54000,56317.4201,56317.4201,56317.4201 diff --git a/tests/testthat/test-formulas.R b/tests/testthat/test-formulas.R index 3352f59..c65024f 100644 --- a/tests/testthat/test-formulas.R +++ b/tests/testthat/test-formulas.R @@ -13,8 +13,14 @@ mki_ki_data <- read.csv( rprojroot::find_testthat_root_file("data/mki_ki_data.csv") ) -mki_ki_assessed <- mki_ki_data$Assessed -mki_ki_sale_price <- mki_ki_data$Sale_Price + +tb_path <- testthat::test_path("data", "mki_ki_data_with_tiebreaks.csv") +tb_df <- readr::read_csv(tb_path, show_col_types = FALSE) + +mki_ki_data_with_tiebreaks_Sale_Price <- tb_df$Sale_Price +mki_ki_data_with_tiebreaks_Assessed <- tb_df$Assessed +mki_ki_data_with_tiebreaks_Assessed_alt_sort_1 <- tb_df$Assessed_alt_sort_1 +mki_ki_data_with_tiebreaks_Assessed_alt_sort_2 <- tb_df$Assessed_alt_sort_2 @@ -184,6 +190,60 @@ test_that("standard met function", { expect_false(mki_met(mki_out)) }) +##### TEST MKI ##### +context("test mki function") + +# Calculate MKI +mki_out <- mki(mki_ki_assessed, mki_ki_sale_price) + +test_that("returns expected type", { + expect_type(mki_out, "double") + expect_vector(mki_out) +}) + +test_that("output equal to expected", { + expect_equal(mki_out, 0.79, tolerance = 0.01) +}) + +test_that("bad input data stops execution", { + expect_error(mki(numeric(0))) + expect_error(mki(numeric(10), numeric(10))) + expect_error(mki(c(mki_ki_assessed, Inf), c(mki_ki_sale_price, 0))) + expect_error(mki(mki_ki_assessed, c(mki_ki_sale_price, 10e5))) + expect_error(mki(data.frame(mki_ki_assessed), mki_ki_sale_price)) + expect_error(mki(c(mki_ki_assessed, NaN), c(mki_ki_sale_price, 1))) + expect_error(mki(c(mki_ki_assessed, "2"), c(mki_ki_sale_price, 1))) + expect_error(mki(mki_ki_assessed, mki_ki_sale_price, na.rm = "yes")) +}) + +test_that("incomplete data returns NAs unless removed", { + expect_equal( + mki(c(mki_ki_assessed, NA), c(mki_ki_sale_price, 10e5)), + NA_real_ + ) + expect_equal( + mki(c(mki_ki_assessed, NA), c(mki_ki_sale_price, 10e5), na.rm = TRUE), + 0.79, + tolerance = 0.01 + ) +}) + +test_that("standard met function", { + expect_false(mki_met(mki_out)) +}) + +test_that("all estimate variants return the same MKI (tiebreak data)", { + mki_out_assessed <- mki(mki_ki_data_with_tiebreaks_Sale_Price, + mki_ki_data_with_tiebreaks_Assessed) + mki_out_assessed_alt_sort1 <- mki(mki_ki_data_with_tiebreaks_Sale_Price, + mki_ki_data_with_tiebreaks_Assessed_alt_sort_1) + mki_out_assessed_alt_sort2 <- mki(mki_ki_data_with_tiebreaks_Sale_Price, + mki_ki_data_with_tiebreaks_Assessed_alt_sort_2) + + expect_equal(mki_out_assessed, mki_out_assessed_alt_sort1) + expect_equal(mki_out_assessed, mki_out_assessed_alt_sort2) +}) + ##### TEST KI ##### @@ -225,6 +285,8 @@ test_that("incomplete data returns NAs unless removed", { }) + + ##### TEST Median Ratio ##### context("test median_ratio_met function") From 36388b8545de59a852cb1564f52b422d1fba7cf8 Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Wed, 3 Sep 2025 19:38:23 +0000 Subject: [PATCH 06/11] delete duplicate --- tests/testthat/test-formulas.R | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/tests/testthat/test-formulas.R b/tests/testthat/test-formulas.R index c65024f..11a3c7b 100644 --- a/tests/testthat/test-formulas.R +++ b/tests/testthat/test-formulas.R @@ -190,32 +190,6 @@ test_that("standard met function", { expect_false(mki_met(mki_out)) }) -##### TEST MKI ##### -context("test mki function") - -# Calculate MKI -mki_out <- mki(mki_ki_assessed, mki_ki_sale_price) - -test_that("returns expected type", { - expect_type(mki_out, "double") - expect_vector(mki_out) -}) - -test_that("output equal to expected", { - expect_equal(mki_out, 0.79, tolerance = 0.01) -}) - -test_that("bad input data stops execution", { - expect_error(mki(numeric(0))) - expect_error(mki(numeric(10), numeric(10))) - expect_error(mki(c(mki_ki_assessed, Inf), c(mki_ki_sale_price, 0))) - expect_error(mki(mki_ki_assessed, c(mki_ki_sale_price, 10e5))) - expect_error(mki(data.frame(mki_ki_assessed), mki_ki_sale_price)) - expect_error(mki(c(mki_ki_assessed, NaN), c(mki_ki_sale_price, 1))) - expect_error(mki(c(mki_ki_assessed, "2"), c(mki_ki_sale_price, 1))) - expect_error(mki(mki_ki_assessed, mki_ki_sale_price, na.rm = "yes")) -}) - test_that("incomplete data returns NAs unless removed", { expect_equal( mki(c(mki_ki_assessed, NA), c(mki_ki_sale_price, 10e5)), From 824bf891164c9ffad0b2ccdc88310ec61ccfedbd Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Wed, 3 Sep 2025 19:42:50 +0000 Subject: [PATCH 07/11] cleanup --- tests/testthat/test-formulas.R | 32 +++++++++++++++++++------------- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/tests/testthat/test-formulas.R b/tests/testthat/test-formulas.R index 11a3c7b..28e4d92 100644 --- a/tests/testthat/test-formulas.R +++ b/tests/testthat/test-formulas.R @@ -13,14 +13,14 @@ mki_ki_data <- read.csv( rprojroot::find_testthat_root_file("data/mki_ki_data.csv") ) +mki_tiebreaks <- read.csv( + rprojroot::find_testthat_root_file("data/mki_ki_data_with_tiebreaks.csv") +) -tb_path <- testthat::test_path("data", "mki_ki_data_with_tiebreaks.csv") -tb_df <- readr::read_csv(tb_path, show_col_types = FALSE) - -mki_ki_data_with_tiebreaks_Sale_Price <- tb_df$Sale_Price -mki_ki_data_with_tiebreaks_Assessed <- tb_df$Assessed -mki_ki_data_with_tiebreaks_Assessed_alt_sort_1 <- tb_df$Assessed_alt_sort_1 -mki_ki_data_with_tiebreaks_Assessed_alt_sort_2 <- tb_df$Assessed_alt_sort_2 +tiebreaks_Sale_Price <- mki_tiebreaks$Sale_Price +tiebreaks_Assessed <- mki_tiebreaks$Assessed +tiebreaks_Assessed_alt_sort_1 <- mki_tiebreaks$Assessed_alt_sort_1 +tiebreaks_Assessed_alt_sort_2 <- mki_tiebreaks$Assessed_alt_sort_2 @@ -207,12 +207,18 @@ test_that("standard met function", { }) test_that("all estimate variants return the same MKI (tiebreak data)", { - mki_out_assessed <- mki(mki_ki_data_with_tiebreaks_Sale_Price, - mki_ki_data_with_tiebreaks_Assessed) - mki_out_assessed_alt_sort1 <- mki(mki_ki_data_with_tiebreaks_Sale_Price, - mki_ki_data_with_tiebreaks_Assessed_alt_sort_1) - mki_out_assessed_alt_sort2 <- mki(mki_ki_data_with_tiebreaks_Sale_Price, - mki_ki_data_with_tiebreaks_Assessed_alt_sort_2) + mki_out_assessed <- mki( + tiebreaks_Sale_Price, + tiebreaks_Assessed + ) + mki_out_assessed_alt_sort1 <- mki( + tiebreaks_Sale_Price, + tiebreaks_Assessed_alt_sort_1 + ) + mki_out_assessed_alt_sort2 <- mki( + tiebreaks_Sale_Price, + tiebreaks_Assessed_alt_sort_2 + ) expect_equal(mki_out_assessed, mki_out_assessed_alt_sort1) expect_equal(mki_out_assessed, mki_out_assessed_alt_sort2) From 78d8ffb97cd2a800a6fd9f870d13409075202d7a Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Wed, 3 Sep 2025 19:51:38 +0000 Subject: [PATCH 08/11] cleanup --- tests/testthat/test-formulas.R | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/tests/testthat/test-formulas.R b/tests/testthat/test-formulas.R index 28e4d92..0fa6976 100644 --- a/tests/testthat/test-formulas.R +++ b/tests/testthat/test-formulas.R @@ -13,6 +13,9 @@ mki_ki_data <- read.csv( rprojroot::find_testthat_root_file("data/mki_ki_data.csv") ) +mki_ki_assessed <- mki_ki_data$Assessed +mki_ki_sale_price <- mki_ki_data$Sale_Price + mki_tiebreaks <- read.csv( rprojroot::find_testthat_root_file("data/mki_ki_data_with_tiebreaks.csv") ) @@ -174,18 +177,6 @@ test_that("bad input data stops execution", { expect_error(mki(mki_ki_assessed, mki_ki_sale_price, na.rm = "yes")) }) -test_that("incomplete data returns NAs unless removed", { - expect_equal( - mki(c(mki_ki_assessed, NA), c(mki_ki_sale_price, 10e5)), - NA_real_ - ) - expect_equal( - mki(c(mki_ki_assessed, NA), c(mki_ki_sale_price, 10e5), na.rm = TRUE), - 0.79, - tolerance = 0.01 - ) -}) - test_that("standard met function", { expect_false(mki_met(mki_out)) }) @@ -202,10 +193,6 @@ test_that("incomplete data returns NAs unless removed", { ) }) -test_that("standard met function", { - expect_false(mki_met(mki_out)) -}) - test_that("all estimate variants return the same MKI (tiebreak data)", { mki_out_assessed <- mki( tiebreaks_Sale_Price, From 1229f4587d5f52d134392aaf1eec048ffe10678a Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Wed, 3 Sep 2025 20:00:41 +0000 Subject: [PATCH 09/11] Add ki --- tests/testthat/test-formulas.R | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/tests/testthat/test-formulas.R b/tests/testthat/test-formulas.R index 0fa6976..7ce1466 100644 --- a/tests/testthat/test-formulas.R +++ b/tests/testthat/test-formulas.R @@ -177,10 +177,6 @@ test_that("bad input data stops execution", { expect_error(mki(mki_ki_assessed, mki_ki_sale_price, na.rm = "yes")) }) -test_that("standard met function", { - expect_false(mki_met(mki_out)) -}) - test_that("incomplete data returns NAs unless removed", { expect_equal( mki(c(mki_ki_assessed, NA), c(mki_ki_sale_price, 10e5)), @@ -193,6 +189,10 @@ test_that("incomplete data returns NAs unless removed", { ) }) +test_that("standard met function", { + expect_false(mki_met(mki_out)) +}) + test_that("all estimate variants return the same MKI (tiebreak data)", { mki_out_assessed <- mki( tiebreaks_Sale_Price, @@ -212,7 +212,6 @@ test_that("all estimate variants return the same MKI (tiebreak data)", { }) - ##### TEST KI ##### context("test ki function") @@ -251,7 +250,23 @@ test_that("incomplete data returns NAs unless removed", { ) }) +test_that("all estimate variants return the same ki (tiebreak data)", { + ki_out_assessed <- ki( + tiebreaks_Sale_Price, + tiebreaks_Assessed + ) + ki_out_assessed_alt_sort1 <- ki( + tiebreaks_Sale_Price, + tiebreaks_Assessed_alt_sort_1 + ) + ki_out_assessed_alt_sort2 <- ki( + tiebreaks_Sale_Price, + tiebreaks_Assessed_alt_sort_2 + ) + expect_equal(ki_out_assessed, ki_out_assessed_alt_sort1) + expect_equal(ki_out_assessed, ki_out_assessed_alt_sort2) +}) ##### TEST Median Ratio ##### From 98116566f955b6e2343cd74c9826d7d4611c058b Mon Sep 17 00:00:00 2001 From: Damonamajor <56321109+Damonamajor@users.noreply.github.com> Date: Wed, 3 Sep 2025 15:09:29 -0500 Subject: [PATCH 10/11] rename test --- tests/testthat/test-formulas.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testthat/test-formulas.R b/tests/testthat/test-formulas.R index 7ce1466..8ae1c83 100644 --- a/tests/testthat/test-formulas.R +++ b/tests/testthat/test-formulas.R @@ -193,7 +193,7 @@ test_that("standard met function", { expect_false(mki_met(mki_out)) }) -test_that("all estimate variants return the same MKI (tiebreak data)", { +test_that("all sorting variations return the same MKI (tiebreak data)", { mki_out_assessed <- mki( tiebreaks_Sale_Price, tiebreaks_Assessed @@ -250,7 +250,7 @@ test_that("incomplete data returns NAs unless removed", { ) }) -test_that("all estimate variants return the same ki (tiebreak data)", { +test_that("all sorting variations return return the same ki (tiebreak data)", { ki_out_assessed <- ki( tiebreaks_Sale_Price, tiebreaks_Assessed From 69decd3c3b4a6b5acb9d1c55298aa61433e819b9 Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Thu, 4 Sep 2025 14:47:54 +0000 Subject: [PATCH 11/11] switch mki ki order --- tests/testthat/test-formulas.R | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/tests/testthat/test-formulas.R b/tests/testthat/test-formulas.R index 7ce1466..2cd87b5 100644 --- a/tests/testthat/test-formulas.R +++ b/tests/testthat/test-formulas.R @@ -195,16 +195,15 @@ test_that("standard met function", { test_that("all estimate variants return the same MKI (tiebreak data)", { mki_out_assessed <- mki( - tiebreaks_Sale_Price, - tiebreaks_Assessed + tiebreaks_Assessed, tiebreaks_Sale_Price ) mki_out_assessed_alt_sort1 <- mki( - tiebreaks_Sale_Price, - tiebreaks_Assessed_alt_sort_1 + tiebreaks_Assessed_alt_sort_1, + tiebreaks_Sale_Price ) mki_out_assessed_alt_sort2 <- mki( - tiebreaks_Sale_Price, - tiebreaks_Assessed_alt_sort_2 + tiebreaks_Assessed_alt_sort_2, + tiebreaks_Sale_Price ) expect_equal(mki_out_assessed, mki_out_assessed_alt_sort1) @@ -252,16 +251,16 @@ test_that("incomplete data returns NAs unless removed", { test_that("all estimate variants return the same ki (tiebreak data)", { ki_out_assessed <- ki( - tiebreaks_Sale_Price, - tiebreaks_Assessed + tiebreaks_Assessed, + tiebreaks_Sale_Price ) ki_out_assessed_alt_sort1 <- ki( - tiebreaks_Sale_Price, - tiebreaks_Assessed_alt_sort_1 + tiebreaks_Assessed_alt_sort_1, + tiebreaks_Sale_Price ) ki_out_assessed_alt_sort2 <- ki( - tiebreaks_Sale_Price, - tiebreaks_Assessed_alt_sort_2 + tiebreaks_Assessed_alt_sort_2, + tiebreaks_Sale_Price ) expect_equal(ki_out_assessed, ki_out_assessed_alt_sort1)