Mosaic pipeline #42
Open
Mosaic pipeline #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madelinehazel
requested changes
May 4, 2022
cre.gemini.variant_impacts.vcf2db.sh
Outdated
| #if pipeline is cre, filter out variants only called by one of freebayes, samtools, platypus | ||
| callers=`gemini db_info $file | grep -w "variants" | grep -w "callers"` | ||
| if [ ! -z "$callers" ] | ||
| if [ ! -z "$callers" ] && [ "$type" != "wes.mosaic" ] |
Contributor
There was a problem hiding this comment.
Does 'callers' exist in the mosaic gemini db? If so you can remove && [ "$type" != "wes.mosaic" ]
Member
Author
There was a problem hiding this comment.
Since mosaic pipeline uses only one caller, I didn't set "callers" variable. Therefore there is no callers in gemini db_info
cre.gemini.variant_impacts.vcf2db.sh
Outdated
| then | ||
| callers="v.callers" | ||
| caller_filter="and v.callers not in ('freebayes', 'samtools', 'platypus')" | ||
| elif [ ! -z "$callers" ] && [ "$type" == "wes.mosaic" ] |
Contributor
There was a problem hiding this comment.
If the above is true, you can remove this conditional block
cre.gemini2txt.vcf2db.sh
Outdated
| #if pipeline is cre, filter out variants only called by one of freebayes, samtools, platypus | ||
| callers=`gemini db_info $file | grep -w "variants" | grep -w "callers"` | ||
| if [ ! -z "$callers" ] | ||
| if [ ! -z "$callers" ] && [ "$type" != "wes.mosaic" ] |
Contributor
There was a problem hiding this comment.
same comments as above
cre.sh
Outdated
| ln -s ${family}-precalled.db ${family}-ensemble.db | ||
| ln -s ${family}-precalled-annotated-decomposed.vcf.gz ${family}-ensemble-annotated-decomposed.vcf.gz | ||
| ln -s ${family}-precalled-annotated-decomposed.vcf.gz.tbi ${family}-ensemble-annotated-decomposed.vcf.gz.tbi | ||
| #elif [ "$type" == "wes.mosaic"] |
Contributor
There was a problem hiding this comment.
Can we remove these lines?
Madelinehazel
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added mosaic option to generate wes.mosaic report