From d6e22a118354f9d68a1e642df2a4f527bf0c8602 Mon Sep 17 00:00:00 2001 From: qiujiantao Date: Thu, 13 Mar 2025 15:19:15 +0800 Subject: [PATCH] fix: simplify test cases by directly setting CACHE_TMP_DIR mock value --- .../model/resource_utils/test_download_assets.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/llm_web_kit/model/resource_utils/test_download_assets.py b/tests/llm_web_kit/model/resource_utils/test_download_assets.py index b51b37f4..ecd6a39b 100644 --- a/tests/llm_web_kit/model/resource_utils/test_download_assets.py +++ b/tests/llm_web_kit/model/resource_utils/test_download_assets.py @@ -65,10 +65,9 @@ def test_s3_connection(self, mock_client): class TestDownloadCoreFunctionality(unittest.TestCase): - @patch('llm_web_kit.model.resource_utils.download_assets.CACHE_TMP_DIR') + @patch('llm_web_kit.model.resource_utils.download_assets.CACHE_TMP_DIR', '/tmp') @patch('llm_web_kit.model.resource_utils.download_assets.S3Connection') - def test_successful_download(self, mock_conn, mock_cache_tmp_dir): - mock_cache_tmp_dir.return_value = '/tmp' + def test_successful_download(self, mock_conn): # Mock connection download_data = b'data' mock_instance = MagicMock() @@ -83,10 +82,9 @@ def test_successful_download(self, mock_conn, mock_cache_tmp_dir): assert result == target assert os.path.exists(target) - @patch('llm_web_kit.model.resource_utils.download_assets.CACHE_TMP_DIR') + @patch('llm_web_kit.model.resource_utils.download_assets.CACHE_TMP_DIR', '/tmp') @patch('llm_web_kit.model.resource_utils.download_assets.HttpConnection') - def test_size_mismatch(self, mock_conn, mock_cache_tmp_dir): - mock_cache_tmp_dir.return_value = '/tmp' + def test_size_mismatch(self, mock_conn): download_data = b'data' mock_instance = MagicMock() mock_instance.read_stream.return_value = [download_data]