-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Description
Here in the code, the boolean parsing is incorrect.
It should be something like byte == b'T' instead of byte != 0.
And byte == 0 is used for a NULL value, see section 7.3.3.1 of the FITS document.
I image two solutions:
- add a
Nullto theDataValueenum - replace
boolbyOption<bool>forvalueinDataValue::Logical
Which one do you prefer (I have not looked enough at fitsrs to have an opinion)?
P.S: in AT2S I use both a Field::Boolean(bool) and Field::NullableBoolean(Option<bool>) so I then to favor the second option in the above list.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels