added is_testing env variable so that requires work better with auto bundlers like vite #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bundlers like vite
ceifa
reviewed
Mar 4, 2025
index.js
Outdated
| * @returns {Omit<Client, 'init' | 'runCallbacks'>} | ||
| */ | ||
| module.exports.init = (appId) => { | ||
| module.exports.init = (appId, networking) => { |
Author
There was a problem hiding this comment.
Ahh good catch. this was not intentional. Forked this from my networking branch.
Owner
|
I don't get how this change makes sense. Vite and other bundlers should handle relative requires just fine. |
Author
|
I was having major issues with vite, it simply would not handle the relative requires unless I split this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title, I also set the process.env.IS_TESTING = true on all of the test scripts so that it utilizes the local package instead.