reana: access token implementation

 * Closes #1113.

Signed-off-by: Ioannis Tsanaktsidis <ioannis.tsanaktsidis@cern.ch>

Author: ioannistsanaktsidis

cap/config.py

@@ -640,5 +640,13 @@ def _(x):
 
 # Reana server url
 # ================
-REANA_ACCESS_TOKEN = os.environ.get(
-    'APP_REANA_ACCESS_TOKEN', None)
+REANA_ACCESS_TOKEN = {
+    'ATLAS': os.environ.get(
+        'APP_REANA_ATLAS_ACCESS_TOKEN', None),
+    'ALICE': os.environ.get(
+        'APP_REANA_ALICE_ACCESS_TOKEN', None),
+    'CMS': os.environ.get(
+        'APP_REANA_CMS_ACCESS_TOKEN', None),
+    'LHCb': os.environ.get(
+        'APP_REANA_LHCb_ACCESS_TOKEN', None)
+}

cap/modules/reana/errors.py

@@ -0,0 +1,39 @@
+# -*- coding: utf-8 -*-
+#
+# This file is part of CERN Analysis Preservation Framework.
+# Copyright (C) 2018 CERN.
+#
+# CERN Analysis Preservation Framework is free software; you can redistribute
+# it and/or modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of the
+# License, or (at your option) any later version.
+#
+# CERN Analysis Preservation Framework is distributed in the hope that it will
+# be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with CERN Analysis Preservation Framework; if not, write to the
+# Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307, USA.
+#
+# In applying this license, CERN does not
+# waive the privileges and immunities granted to it by virtue of its status
+# as an Intergovernmental Organization or submit itself to any jurisdiction.
+
+"""Reana exceptions."""
+
+from invenio_rest.errors import RESTException
+
+
+class ExperimentIsNotValid(RESTException):
+    """Experiment not present."""
+
+    code = 400
+
+    def __init__(self, description, **kwargs):
+        """Initialize exception."""
+        super(ExperimentIsNotValid, self).__init__(**kwargs)
+
+        self.description = description or self.description

cap/modules/reana/views.py

@@ -24,16 +24,19 @@
 
 
 """CAP REANA views."""
+import json
 
 from flask import Blueprint, abort, current_app, jsonify, request
 
 from flask_login import current_user
-from invenio_pidstore.models import PersistentIdentifier, PIDDoesNotExistError
 
+from invenio_pidstore.models import PersistentIdentifier, PIDDoesNotExistError
 from invenio_db import db
-import json
+
+from .errors import ExperimentIsNotValid
 from .models import ReanaJob
 from .serializers import ReanaJobSchema
+from cap.modules.records.api import CAPRecord
 from reana_client.api.client import create_workflow_from_json, \
     start_workflow, get_workflow_status, get_workflow_logs
 
@@ -78,15 +81,25 @@ def create_workflow():
             "mc15_13TeV.123456.cap_recast_demo_signal_one.root"
         }
     }
-    access_token = current_app.config.get('REANA_ACCESS_TOKEN')
-    response = create_workflow_from_json(
-        workflow_json, name, access_token, parameters, workflow_engine)
 
     try:
         uuid = PersistentIdentifier.get('recid', record_id).object_uuid
+        experiment = CAPRecord.get_record(uuid).get('_experiment', None)
+        if experiment is None:
+            raise ExperimentIsNotValid('Experiment is not valid.')
+        access_token = current_app.config.get(
+            'REANA_ACCESS_TOKEN').get(experiment, None)
+        if access_token is None:
+            raise ExperimentIsNotValid(
+                'Access token for {} is not available'.format(
+                    experiment))
+
     except PIDDoesNotExistError:
         abort(404)
 
+    response = create_workflow_from_json(
+        workflow_json, name, access_token, parameters, workflow_engine)
+
     reana_job = ReanaJob(
         user_id=current_user.id,
         record_id=uuid,

tests/conftest.py

@@ -312,7 +312,8 @@ def create_deposit(app, db, es, location, jsonschemas_host,
 
     with db_.session.begin_nested():
 
-        def _create_deposit(user, schema_name, metadata=None, experiment=None, publish=False):
+        def _create_deposit(user, schema_name,
+                            metadata=None, experiment=None, publish=False):
             """
             Create a new deposit for given user and schema name
             e.g cms-analysis-v0.0.1,
@@ -364,6 +365,14 @@ def deposit(users, create_deposit):
     return create_deposit(users['superuser'], 'cms-analysis-v0.0.1')
 
 
+@pytest.fixture
+def record(users, create_deposit):
+    return create_deposit(users['superuser'],
+                          'cms-analysis-v0.0.1',
+                          experiment='CMS',
+                          publish=True)
+
+
 @pytest.fixture
 def record_metadata(deposit):
     return deposit.get_record_metadata()

tests/integration/test_api_reana.py

@@ -28,23 +28,42 @@
 
 import json
 
-from pytest import mark
+from invenio_pidstore.models import PersistentIdentifier
 from cap.modules.reana.models import ReanaJob
 
+#################
+# api/reana/create
+#################
+
+
+def test_create_workflow_returns_404_when_record_does_not_exist(app,
+                                                                auth_headers_for_superuser,
+                                                                json_headers):
+    data = {
+        'record_id': 'wrong_pid',
+        'workflow_name': 'test_workflow',
+        'workflow_json': {}
+    }
+    with app.test_client() as client:
+        resp = client.post('/reana/create', data=json.dumps(data),
+                           headers=auth_headers_for_superuser + json_headers)
+
+        assert resp.status_code == 404
+
 
 #################
 # api/reana/jobs
 #################
-@mark.skip
-def test_get_reana_jobs_when_user_not_logged_in_returns_401(app, users, deposit):
+
+def test_get_reana_jobs_when_user_not_logged_in_returns_401(app, users, record):
     with app.test_client() as client:
-        resp = client.get('/reana/jobs/{}'.format(deposit.id))
+        resp = client.get(
+            '/reana/jobs/{}'.format(record['_deposit']['pid']['value']))
 
         assert resp.status_code == 401
 
 
-@mark.skip
-def test_get_reana_jobs_when_depid_doesnt_exists_returns_404(app,
+def test_get_reana_jobs_when_recid_doesnt_exists_returns_404(app,
                                                              auth_headers_for_superuser):
     with app.test_client() as client:
         resp = client.get('/reana/jobs/{}'.format('non-existing-pid'),
@@ -53,23 +72,24 @@ def test_get_reana_jobs_when_depid_doesnt_exists_returns_404(app,
         assert resp.status_code == 404
 
 
-@mark.skip
 def test_get_reana_jobs_when_no_jobs_returns_empty_list(app, auth_headers_for_superuser,
-                                                        deposit):
+                                                        record):
     with app.test_client() as client:
-        resp = client.get('/reana/jobs/{}'.format(deposit['_deposit']['id']),
+        resp = client.get('/reana/jobs/{}'.format(record['_deposit']['pid']['value']),
                           headers=auth_headers_for_superuser)
 
         assert json.loads(resp.data) == []
 
 
-@mark.skip
 def test_get_reana_jobs_returns_list_with_user_jobs(db, app, users,
                                                     auth_headers_for_superuser,
-                                                    deposit):
+                                                    record):
+
+    uuid = PersistentIdentifier.get('recid', record['_deposit'][
+                                    'pid']['value']).object_uuid
     db.session.add(ReanaJob(
-        user=users['superuser'],
-        record=deposit.get_record_metadata(),
+        user_id=users['superuser'].id,
+        record_id=uuid,
         name='my_workflow_run',
         params={
             'param_1': 1,
@@ -78,8 +98,9 @@ def test_get_reana_jobs_returns_list_with_user_jobs(db, app, users,
     db.session.commit()
 
     with app.test_client() as client:
-        resp = client.get('/reana/jobs/{}'.format(deposit['_deposit']['id']),
-                          headers=auth_headers_for_superuser)
+        resp = client.get('/reana/jobs/{}'.format(
+            record['_deposit']['pid']['value']),
+            headers=auth_headers_for_superuser)
 
         serialized_reana_job = {
             'name': 'my_workflow_run',