Skip to content

Commit f9aea50

Browse files
committed
cms: catch validation error exception on cadi sync
Signed-off-by: Pamfilos Fokianos <pamfilosf@gmail.com>
1 parent 035c04f commit f9aea50

File tree

1 file changed

+8
-4
lines changed
  • cap/modules/experiments/utils

1 file changed

+8
-4
lines changed

cap/modules/experiments/utils/cadi.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@
3333
from invenio_search import RecordsSearch
3434

3535
from cap.modules.deposit.api import CAPDeposit
36-
from cap.modules.deposit.errors import DepositDoesNotExist
36+
from cap.modules.deposit.errors import (DepositDoesNotExist,
37+
DepositValidationError)
3738
from cap.modules.user.errors import DoesNotExistInLDAP
3839
from cap.modules.user.utils import (get_existing_or_register_role,
3940
get_existing_or_register_user,
@@ -83,17 +84,20 @@ def _cadi_deposit(cadi_id, cadi_info):
8384

8485
try: # update if cadi deposit already exists
8586
deposit = get_deposit_by_cadi_id(cadi_id)
86-
8787
if deposit.get('cadi_info') == cadi_info:
8888
current_app.logger.info(f'No changes in entry {cadi_id}.')
8989

9090
else:
9191
deposit['cadi_info'] = cadi_info
92-
deposit.commit()
92+
try:
93+
deposit.commit()
94+
except DepositValidationError:
95+
current_app.logger.exception(
96+
f'Error during updating cadi info in {cadi_id}.')
97+
continue
9398
db.session.commit()
9499

95100
current_app.logger.info(f'Cadi entry {cadi_id} updated.')
96-
97101
except DepositDoesNotExist:
98102
try:
99103
with db.session.begin_nested():

0 commit comments

Comments
 (0)