From e3e87c1b7b41e0fb1525e630d6f0405dea0ac718 Mon Sep 17 00:00:00 2001 From: Nicolas Pennec Date: Thu, 11 Dec 2025 09:14:54 +0100 Subject: [PATCH 01/22] [qa] fix edge case of undefined value --- src/components/previews/BrowsingBar.vue | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/components/previews/BrowsingBar.vue b/src/components/previews/BrowsingBar.vue index 47ee1ba0c7..1a2b5e1cd0 100644 --- a/src/components/previews/BrowsingBar.vue +++ b/src/components/previews/BrowsingBar.vue @@ -97,11 +97,7 @@ export default { }, isMovie() { - if (this.previews.length < this.currentIndex) { - return false - } else { - return this.previews[this.currentIndex - 1].extension === 'mp4' - } + return this.previews[this.currentIndex - 1]?.extension === 'mp4' } } } From 4b759e43b9ec72138e6da81399b2bff72f651dde Mon Sep 17 00:00:00 2001 From: Nicolas Pennec Date: Thu, 11 Dec 2025 09:54:54 +0100 Subject: [PATCH 02/22] [qa] fix edge case of undefined value Comment is not used by the endpoint --- src/components/pages/Task.vue | 2 +- src/components/sides/TaskInfo.vue | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/pages/Task.vue b/src/components/pages/Task.vue index 096f366651..8a9d2290ec 100644 --- a/src/components/pages/Task.vue +++ b/src/components/pages/Task.vue @@ -1288,7 +1288,7 @@ export default { this.$refs['preview-player'].displayFirst() this.deleteTaskPreview({ taskId: this.task.id, - commentId: comment.id, + commentId: comment?.id, previewId: this.currentExtraPreviewId }) .then(() => { diff --git a/src/components/sides/TaskInfo.vue b/src/components/sides/TaskInfo.vue index 582f920973..0725f5103f 100644 --- a/src/components/sides/TaskInfo.vue +++ b/src/components/sides/TaskInfo.vue @@ -1238,7 +1238,7 @@ export default { this.$refs['preview-player'].displayFirst() this.deleteTaskPreview({ taskId: this.task.id, - commentId: comment.id, + commentId: comment?.id, previewId }) .then(() => { From fdf75e2116cb3b4ca95089a57e177ff420accb2a Mon Sep 17 00:00:00 2001 From: Nicolas Pennec Date: Thu, 11 Dec 2025 10:46:11 +0100 Subject: [PATCH 03/22] [qa] fix edge case of undefined value Current production can be undefined on logout --- src/components/pages/Shots.vue | 4 +++- src/store/modules/sequences.js | 5 +++++ src/store/modules/shots.js | 5 +++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/components/pages/Shots.vue b/src/components/pages/Shots.vue index d366fab192..ec56b28b73 100644 --- a/src/components/pages/Shots.vue +++ b/src/components/pages/Shots.vue @@ -454,7 +454,9 @@ export default { const finalize = () => { this.$nextTick(() => { // Needed to be sure the current production is set - this.loadShots() + this.loadShots(() => { + this.initialLoading = false + }) }) } diff --git a/src/store/modules/sequences.js b/src/store/modules/sequences.js index 1c1fd5cb32..9ad6fbb8ce 100644 --- a/src/store/modules/sequences.js +++ b/src/store/modules/sequences.js @@ -380,6 +380,11 @@ const actions = { const taskMap = rootGetters.taskMap const taskStatusMap = rootGetters.taskStatusMap const taskTypeMap = rootGetters.taskTypeMap + + if (!production) { + return [] + } + if (!episode && isTVShow) { if (rootGetters.episodes && rootGetters.episodes.length > 0) { episode = rootGetters.episodes[0] diff --git a/src/store/modules/shots.js b/src/store/modules/shots.js index e6de06eb2d..58c3451b5f 100644 --- a/src/store/modules/shots.js +++ b/src/store/modules/shots.js @@ -403,6 +403,11 @@ const actions = { const isTVShow = rootGetters.isTVShow let episode = isTVShow ? rootGetters.currentEpisode : null + if (!production) { + if (callback) return callback() + return + } + if (episode && ['all', 'main'].includes(episode.id)) { // If it's a wide episode, we just store it. There isn't anything to // load because we don't have episode defined. From 0e261fe380217421b291328544e33b47d25bf356 Mon Sep 17 00:00:00 2001 From: Nicolas Pennec Date: Thu, 11 Dec 2025 11:20:27 +0100 Subject: [PATCH 04/22] [qa] fix edge case of undefined value And cleanup widget --- src/components/cells/DepartmentNamesCell.vue | 24 +++++++++----------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/components/cells/DepartmentNamesCell.vue b/src/components/cells/DepartmentNamesCell.vue index cbea318104..01b33106c4 100644 --- a/src/components/cells/DepartmentNamesCell.vue +++ b/src/components/cells/DepartmentNamesCell.vue @@ -1,12 +1,10 @@ @@ -32,13 +30,13 @@ export default { }, computed: { - ...mapGetters(['departmentMap']) - }, + ...mapGetters(['departmentMap']), - methods: { - sortDepartments(departmentIds = []) { + sortedDepartments() { return sortByName( - departmentIds.map(departmentId => this.departmentMap.get(departmentId)) + this.departments + .map(departmentId => this.departmentMap.get(departmentId)) + .filter(Boolean) ) } } From 2d4c588b095e2d04d928ce024667d52c3c37e653 Mon Sep 17 00:00:00 2001 From: Nicolas Pennec Date: Thu, 11 Dec 2025 11:22:06 +0100 Subject: [PATCH 05/22] [qa] remove useless css --- src/components/lists/PeopleList.vue | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/components/lists/PeopleList.vue b/src/components/lists/PeopleList.vue index a847b1d710..e7ba7fac9f 100644 --- a/src/components/lists/PeopleList.vue +++ b/src/components/lists/PeopleList.vue @@ -281,10 +281,6 @@ export default { .departments { width: 180px; min-width: 180px; - - .departments-element { - padding: 5px; - } } .studio { From 9dd4576d99f4a6481a822f20cff1420eb58fc820 Mon Sep 17 00:00:00 2001 From: Nicolas Pennec Date: Thu, 11 Dec 2025 13:52:43 +0100 Subject: [PATCH 06/22] [widgets] refactor DepartmentName component --- src/components/widgets/DepartmentName.vue | 48 +++++++++++------------ 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/src/components/widgets/DepartmentName.vue b/src/components/widgets/DepartmentName.vue index 874a554588..482e3a76fe 100644 --- a/src/components/widgets/DepartmentName.vue +++ b/src/components/widgets/DepartmentName.vue @@ -1,35 +1,31 @@ - From dcec72383e501e412023aa320623f80c81b318b1 Mon Sep 17 00:00:00 2001 From: Nicolas Pennec Date: Tue, 16 Dec 2025 15:53:10 +0100 Subject: [PATCH 22/22] [tasks] fix the task start date and due date updates A Moment date was set instead of a string date. --- src/components/lists/TaskList.vue | 4 ++-- src/components/lists/TodosList.vue | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/lists/TaskList.vue b/src/components/lists/TaskList.vue index cd316f4d3d..17aa1a94b8 100644 --- a/src/components/lists/TaskList.vue +++ b/src/components/lists/TaskList.vue @@ -645,7 +645,7 @@ export default { } else { data = { start_date: null, - due_date: dueDate + due_date: task.due_date } } if (task.difficulty) { @@ -682,7 +682,7 @@ export default { ) } else { data = { - start_date: startDate, + start_date: task.start_date, due_date: null } } diff --git a/src/components/lists/TodosList.vue b/src/components/lists/TodosList.vue index d85d8c7821..f83d76de8f 100644 --- a/src/components/lists/TodosList.vue +++ b/src/components/lists/TodosList.vue @@ -773,7 +773,7 @@ export default { } else { data = { start_date: null, - due_date: dueDate + due_date: task.due_date } } if (this.isTaskChanged(task, data)) { @@ -807,7 +807,7 @@ export default { ) } else { data = { - start_date: startDate, + start_date: task.start_date, due_date: null } }