Fix SCORM issue with abusive auto-completion of parent items - refs #7191

Author: ywarnier

main/newscorm/learnpath.class.php

@@ -814,6 +814,7 @@ public function autocomplete_parents($item)
                                 error_log('Found one incomplete child of ' . $parent_id . ': ' . $child . ' is ' . $this->items[$child]->get_status(), 0);
                             }
                             $completed = false;
+                            break;
                         }
                     }
                 }
@@ -832,7 +833,7 @@ public function autocomplete_parents($item)
             }
         } else {
             if ($debug) {
-                error_log("#$item is an item doesn't have parents");
+                error_log("#$item is an item that doesn't have parents");
             }
         }
     }

main/newscorm/learnpathItem.class.php

@@ -150,6 +150,17 @@ public function __construct(
         $this->save_on_close = true;
         $this->db_id = $id;
 
+        // Load children list
+        $sql = "SELECT id FROM $items_table WHERE c_id = $course_id AND lp_id = ".$this->lp_id." AND parent_item_id = $id";
+        $res = Database::query($sql);
+        if (Database::num_rows($res) < 1) {
+            // Nothing to do (no children)
+        } else {
+            while ($row = Database::fetch_assoc($res)) {
+                $this->children[] = $row['id'];
+            }
+        }
+
         //$this->seriousgame_mode = $this->get_seriousgame_mode();
         $this->seriousgame_mode = 0;