Skip to content

Commit 38e080f

Browse files
committed
Admin: Fix individual search and assignment of course to URL #multiurl - refs #4721
1 parent 57db2e0 commit 38e080f

File tree

2 files changed

+12
-36
lines changed

2 files changed

+12
-36
lines changed

main/admin/access_url_edit_courses_to_url.php

Lines changed: 10 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@
4242
$xajax->processRequests();
4343
$htmlHeadXtra[] = $xajax->getJavascript('../inc/lib/xajax/');
4444
$htmlHeadXtra[] = '<script>
45-
function add_user_to_url(code, content) {
45+
function add_course_to_url(code, content) {
4646
document.getElementById("course_to_add").value = "";
4747
document.getElementById("ajax_list_courses").innerHTML = "";
48-
destination = document.getElementById("destination_users");
48+
destination = document.getElementById("destination_courses");
4949
destination.options[destination.length] = new Option(content,code);
5050
destination.selectedIndex = -1;
5151
sortOptions(destination.options);
@@ -80,7 +80,7 @@ function remove_item(origin) {
8080
if ($form_sent == 1) {
8181
if ($access_url_id == 0) {
8282
Display::addFlash(Display::return_message(get_lang('SelectURL')));
83-
header('Location: access_url_edit_users_to_url.php?');
83+
header('Location: access_url_edit_courses_to_url.php?');
8484
} elseif (is_array($course_list)) {
8585
UrlManager::update_urls_rel_course($course_list, $access_url_id);
8686
Display::addFlash(Display::return_message(get_lang('CoursesWereEdited')));
@@ -94,7 +94,7 @@ function remove_item(origin) {
9494

9595
echo '<div class="actions">';
9696
echo Display::url(
97-
Display::return_icon('view_more_stats.gif', get_lang('AddUserToURL')),
97+
Display::return_icon('view_more_stats.gif', get_lang('AddCoursesToURL')),
9898
api_get_path(WEB_CODE_PATH).'admin/access_url_add_courses_to_url.php'
9999
);
100100
echo '</div>';
@@ -193,7 +193,7 @@ function remove_item(origin) {
193193
<?php
194194
} else {
195195
?>
196-
<select id="origin_users" name="no_course_list[]" multiple="multiple" size="15" style="width:380px;">
196+
<select id="origin_courses" name="no_course_list[]" multiple="multiple" size="15" style="width:380px;">
197197
<?php
198198
foreach ($no_course_list as $no_course) {
199199
?>
@@ -211,17 +211,17 @@ function remove_item(origin) {
211211
<?php
212212
if ($ajax_search) {
213213
?>
214-
<button class="btn btn-default" type="button" onclick="remove_item(document.getElementById('destination_users'))" >
214+
<button class="btn btn-default" type="button" onclick="remove_item(document.getElementById('destination_courses'))" >
215215
<em class="fa fa-arrow-left"></em>
216216
</button>
217217
<?php
218218
} else {
219219
?>
220-
<button class="btn btn-default" type="button" onclick="moveItem(document.getElementById('origin_users'), document.getElementById('destination_users'))" >
220+
<button class="btn btn-default" type="button" onclick="moveItem(document.getElementById('origin_courses'), document.getElementById('destination_courses'))" >
221221
<em class="fa fa-arrow-right"></em>
222222
</button>
223223
<br /><br />
224-
<button class="btn btn-default" type="button" onclick="moveItem(document.getElementById('destination_users'), document.getElementById('origin_users'))" >
224+
<button class="btn btn-default" type="button" onclick="moveItem(document.getElementById('destination_courses'), document.getElementById('origin_courses'))" >
225225
<em class="fa fa-arrow-left"></em>
226226
</button>
227227
<?php
@@ -230,7 +230,7 @@ function remove_item(origin) {
230230
<br /><br /><br /><br /><br /><br />
231231
</td>
232232
<td align="center">
233-
<select id="destination_users" name="course_list[]" multiple="multiple" size="15" style="width:380px;">
233+
<select id="destination_courses" name="course_list[]" multiple="multiple" size="15" style="width:380px;">
234234
<?php
235235
foreach ($course_list as $course) {
236236
$courseInfo = api_get_course_info_by_id($course['id']); ?>
@@ -294,36 +294,12 @@ function mysort(a, b) {
294294
}
295295

296296
function valide(){
297-
var options = document.getElementById('destination_users').options;
297+
var options = document.getElementById('destination_courses').options;
298298
for (i = 0 ; i<options.length ; i++)
299299
options[i].selected = true;
300300
document.forms.formulaire.submit();
301301
}
302302

303-
function loadUsersInSelect(select) {
304-
var xhr_object = null;
305-
if(window.XMLHttpRequest) // Firefox
306-
xhr_object = new XMLHttpRequest();
307-
else if(window.ActiveXObject) // Internet Explorer
308-
xhr_object = new ActiveXObject("Microsoft.XMLHTTP");
309-
else // XMLHttpRequest non supporté par le navigateur
310-
alert("Votre navigateur ne supporte pas les objets XMLHTTPRequest...");
311-
312-
xhr_object.open("POST", "loadUsersInSelect.ajax.php");
313-
xhr_object.setRequestHeader("Content-Type", "application/x-www-form-urlencoded");
314-
nosessionUsers = makepost(document.getElementById('origin_users'));
315-
sessionUsers = makepost(document.getElementById('destination_users'));
316-
nosessionClasses = makepost(document.getElementById('origin_classes'));
317-
sessionClasses = makepost(document.getElementById('destination_classes'));
318-
xhr_object.send("nosessionusers="+nosessionUsers+"&sessionusers="+sessionUsers+"&nosessionclasses="+nosessionClasses+"&sessionclasses="+sessionClasses);
319-
xhr_object.onreadystatechange = function() {
320-
if(xhr_object.readyState == 4) {
321-
document.getElementById('content_source').innerHTML = result = xhr_object.responseText;
322-
//alert(xhr_object.responseText);
323-
}
324-
}
325-
}
326-
327303
function makepost(select){
328304
var options = select.options;
329305
var ret = "";

main/inc/lib/access_url_edit_courses_to_url_functions.lib.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public function search_courses($needle, $id)
3939
$needle = api_convert_encoding($needle, $charset, 'utf-8');
4040
$needle = Database::escape_string($needle);
4141
// search courses where username or firstname or lastname begins likes $needle
42-
$sql = 'SELECT code, title FROM '.$tbl_course.' u '.
42+
$sql = 'SELECT id, code, title FROM '.$tbl_course.' u '.
4343
' WHERE (title LIKE "'.$needle.'%" '.
4444
' OR code LIKE "'.$needle.'%" '.
4545
' ) '.
@@ -50,7 +50,7 @@ public function search_courses($needle, $id)
5050
while ($course = Database::fetch_array($rs)) {
5151
$i++;
5252
if ($i <= 10) {
53-
$return .= '<a href="javascript: void(0);" onclick="javascript: add_user_to_url(\''.addslashes($course['code']).'\',\''.addslashes($course['title']).' ('.addslashes($course['code']).')'.'\')">'.$course['title'].' ('.$course['code'].')</a><br />';
53+
$return .= '<a href="javascript: void(0);" onclick="javascript: add_course_to_url('.addslashes($course['id']).',\''.addslashes($course['title']).' ('.addslashes($course['code']).')'.'\')">'.$course['title'].' ('.$course['code'].')</a><br />';
5454
} else {
5555
$return .= '...<br />';
5656
}

0 commit comments

Comments
 (0)