Skip to content

Commit 4b284c6

Browse files
committed
Merge pull request #894 from jloguercio/forums
Parcial fix to Agenda(personal and courses)
2 parents a9b94cd + dc6eb0e commit 4b284c6

File tree

2 files changed

+34
-17
lines changed

2 files changed

+34
-17
lines changed

main/inc/lib/agenda.lib.php

Lines changed: 29 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -975,7 +975,7 @@ public function getEvents(
975975
);
976976
$my_course_list = CourseManager::get_courses_list_by_user_id(
977977
api_get_user_id(),
978-
true
978+
false
979979
);
980980
}
981981

@@ -1035,7 +1035,7 @@ public function getEvents(
10351035
$start,
10361036
$end,
10371037
$my_session_id,
1038-
api_get_user_id(),
1038+
$user_id,
10391039
$this->eventOtherSessionColor
10401040
);
10411041
}
@@ -1467,6 +1467,22 @@ public function getCourseEvents(
14671467
} else {
14681468
$where_condition = "( ip.to_user_id = $user_id OR (ip.to_group_id IS NULL OR ip.to_group_id IN (0, ".implode(", ", $group_memberships).")) ) ";
14691469
}
1470+
1471+
if (empty($session_id)) {
1472+
$sessionCondition = "
1473+
(
1474+
agenda.session_id = 0 AND
1475+
ip.session_id IS NULL
1476+
) ";
1477+
} else {
1478+
$sessionCondition = "
1479+
(
1480+
agenda.session_id = $session_id AND
1481+
ip.session_id = $session_id
1482+
) ";
1483+
}
1484+
1485+
14701486

14711487
$sql = "SELECT DISTINCT
14721488
agenda.*,
@@ -1483,10 +1499,10 @@ public function getCourseEvents(
14831499
$where_condition AND
14841500
ip.visibility = '1' AND
14851501
agenda.c_id = $course_id AND
1486-
ip.c_id = $course_id
1502+
ip.c_id = agenda.c_id $sessionCondition
14871503
";
14881504
} else {
1489-
$visibilityCondition = " ip.visibility='1' AND";
1505+
$visibilityCondition = " ip.visibility='1' AND ";
14901506

14911507
if (api_is_allowed_to_edit()) {
14921508
if ($user_id == 0) {
@@ -1496,18 +1512,21 @@ public function getCourseEvents(
14961512
}
14971513
$visibilityCondition = " (ip.visibility IN ('1', '0')) AND ";
14981514
} else {
1499-
$where_condition = " ( ip.to_user_id = ".api_get_user_id()." AND (ip.to_group_id='0' OR ip.to_group_id IS NULL)) OR ";
1515+
$where_condition = " ( (ip.to_user_id = ".api_get_user_id()." OR ip.to_user_id IS NULL) AND ip.to_group_id IS NULL) AND ";
15001516
}
15011517

1502-
$sessionCondition = " agenda.session_id = $session_id AND
1503-
ip.session_id = $session_id ";
1504-
15051518
if (empty($session_id)) {
15061519
$sessionCondition = "
15071520
(
1508-
(agenda.session_id = 0 OR agenda.session_id IS NULL) AND
1509-
(ip.session_id = 0 OR ip.session_id IS NULL)
1521+
agenda.session_id = 0 AND
1522+
ip.session_id IS NULL
15101523
) ";
1524+
} else {
1525+
$sessionCondition = "
1526+
(
1527+
agenda.session_id = $session_id AND
1528+
ip.session_id = $session_id
1529+
) ";
15111530
}
15121531

15131532
$sql = "SELECT DISTINCT
@@ -1525,7 +1544,6 @@ public function getCourseEvents(
15251544
$where_condition
15261545
$visibilityCondition
15271546
agenda.c_id = $course_id AND
1528-
ip.c_id = $course_id AND
15291547
$sessionCondition
15301548
";
15311549
}
@@ -1545,7 +1563,6 @@ public function getCourseEvents(
15451563
}
15461564

15471565
$sql .= $dateCondition;
1548-
15491566
$result = Database::query($sql);
15501567

15511568
$coachCanEdit = false;

main/template/default/agenda/month.tpl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ function checkLength( o, n, min, max ) {
1111
}
1212
function clean_user_select() {
1313
//Cleans the selected attr
14-
$("#users_to_send_id").val('').trigger("chosen:updated");
15-
/*$('#users_to_send_id')
14+
$("#users_to_send").val('').trigger("chosen:updated");
15+
/*$('#users_to_send')
1616
.find('option')
1717
.removeAttr('selected')
1818
.end();*/
@@ -115,10 +115,10 @@ $(document).ready(function() {
115115
clean_user_select();
116116
117117
// Sets the 1st item selected by default
118-
$('#users_to_send_id option').eq(0).attr('selected', 'selected');
118+
$('#users_to_send option').eq(0).attr('selected', 'selected');
119119
120120
// Update chz-select
121-
//$("#users_to_send_id").trigger("chosen:updated");
121+
//$("#users_to_send").trigger("chosen:updated");
122122
123123
if ({{ can_add_events }} == 1) {
124124
var url = '{{ web_agenda_ajax_url }}&a=add_event&start='+start.format('YYYY-MM-DD 00:00:00')+'&end='+end.format('YYYY-MM-DD 00:00:00')+'&all_day='+allDay+'&view='+view.name;
@@ -164,7 +164,7 @@ $(document).ready(function() {
164164
$.ajax({
165165
url: url+'&'+params,
166166
success:function(data) {
167-
var user = $('#users_to_send_id').val();
167+
var user = $('#users_to_send').val();
168168
if (user) {
169169
if (user.length > 1) {
170170
user = 0;

0 commit comments

Comments
 (0)