Internal: Fix psalm error in mail settings migration

Author: AngelFQC

src/CoreBundle/Migrations/Schema/V200/Version20250707212800.php

@@ -34,9 +34,31 @@ private function migrateMailConf(string $oldMailConfPath): array
             return [];
         }
 
-        include $oldMailConfPath;
+        /** @var array{
+         *   SMTP_USER?: string,
+         *   SMTP_PASS?: string,
+         *   SMTP_HOST?: string,
+         *   SMTP_PORT?: string,
+         *   EXCLUDE_JSON?: bool,
+         *   DKIM?: bool,
+         *   DKIM_SELECTOR?: string,
+         *   DKIM_DOMAIN?: string,
+         *   DKIM_PRIVATE_KEY_STRING?: string,
+         *   DKIM_PRIVATE_KEY?: string,
+         *   DKIM_PASSPHRASE?: string,
+         *   XOAUTH2_METHOD?: bool,
+         *   XOAUTH2_URL_AUTHORIZE?: string,
+         *   XOAUTH2_URL_ACCES_TOKEN?: string,
+         *   XOAUTH2_URL_RESOURCE_OWNER_DETAILS?: string,
+         *   XOAUTH2_SCOPES?: string,
+         *   XOAUTH2_CLIENT_ID?: string,
+         *   XOAUTH2_CLIENT_SECRET?: string,
+         *   XOAUTH2_REFRESH_TOKEN?: string,
+         * } $platform_email
+         */
+        $platform_email = [];
 
-        global $platform_email;
+        include $oldMailConfPath;
 
         $mailerScheme = 'null';
         $smtpSecure = $platform_email['SMTP_SECURE'] ?? '';

src/CoreBundle/Migrations/Schema/V200/Version20250721200725.php

@@ -18,14 +18,6 @@ public function up(Schema $schema): void
         $updateRootPath = $this->getUpdateRootPath();
         $oldMailConfPath = $updateRootPath.'/app/config/mail.conf.php';
 
-        $legacyMailConfig = file_exists($oldMailConfPath);
-
-        if ($legacyMailConfig) {
-            include $oldMailConfPath;
-
-            global $platform_email;
-        }
-
         $envFile = $projectDir.'/.env';
 
         $dotenv = new Dotenv();
@@ -67,7 +59,29 @@ public function up(Schema $schema): void
             $settings['mailer_debug_enable'] = !empty($_ENV['SMTP_DEBUG']) ? 'true' : 'false';
         }
 
-        if ($legacyMailConfig) {
+        if (file_exists($oldMailConfPath)) {
+            /** @var array{
+             *   EXCLUDE_JSON?: bool,
+             *   DKIM?: bool,
+             *   DKIM_SELECTOR?: string,
+             *   DKIM_DOMAIN?: string,
+             *   DKIM_PRIVATE_KEY_STRING?: string,
+             *   DKIM_PRIVATE_KEY?: string,
+             *   DKIM_PASSPHRASE?: string,
+             *   XOAUTH2_METHOD?: bool,
+             *   XOAUTH2_URL_AUTHORIZE?: string,
+             *   XOAUTH2_URL_ACCES_TOKEN?: string,
+             *   XOAUTH2_URL_RESOURCE_OWNER_DETAILS?: string,
+             *   XOAUTH2_SCOPES?: string,
+             *   XOAUTH2_CLIENT_ID?: string,
+             *   XOAUTH2_CLIENT_SECRET?: string,
+             *   XOAUTH2_REFRESH_TOKEN?: string,
+             * } $platform_email
+             */
+            $platform_email = [];
+
+            include $oldMailConfPath;
+
             $settings['mailer_exclude_json'] = $platform_email['EXCLUDE_JSON'] ?? false;
 
             $dkim = [