Fixes for behat automated tests

Author: ywarnier

main/admin/user_add.php

@@ -201,7 +201,7 @@ function display_drh_list(){
                             . '<img id="previewImage" >'
                         . '</div>'
                         . '<div>'
-                            . '<button class="btn btn-primary hidden" name="cropButton" id="cropButton"><em class="fa fa-crop"></em> '.get_lang('CropYourPicture').'</button>'
+                            . '<button class="btn btn-primary hidden" name="cropButton" id="cropButton" type="submit"><em class="fa fa-crop"></em> '.get_lang('CropYourPicture').'</button>'
                         . '</div>'
                     . '</div>'
             . '</div>'

tests/features/bootstrap/FeatureContext.php

@@ -274,4 +274,35 @@ public function iInviteAFrienToASocialGroup($friendId, $groupId)
             new Step\When('I press "submit"')
         ];
     }
+    /**
+     * Sometimes the top admin toolbar has form buttons
+     * that conflicts with the main page forms so we need
+     * to disable it
+     * @Given /^Admin top bar is disabled$/
+     */
+    public function adminTopBarIsDisabled()
+    {
+        return [
+            new Step\Given('I am a platform administrator'),
+            new Step\Given('I am on "/main/admin/settings.php"'),
+            new Step\When('I fill in "search_field" with "show_admin_toolbar"'),
+            new Step\When('I press "submit_button"'),
+            new Step\When('I select "do_not_show" from "show_admin_toolbar"'),
+            new Step\When('I press "submit"')
+        ];
+    }
+    /**
+     * @Given /^Admin top bar is enabled$/
+     */
+    public function adminTopBarIsEnabled()
+    {
+        return [
+            new Step\Given('I am a platform administrator'),
+            new Step\Given('I am on "/main/admin/settings.php"'),
+            new Step\When('I fill in "search_field" with "show_admin_toolbar"'),
+            new Step\When('I press "submit_button"'),
+            new Step\When('I select "show_to_admin_and_teachers" from "show_admin_toolbar"'),
+            new Step\When('I press "submit"')
+        ];
+    }
 }

tests/features/createUser.feature

@@ -26,6 +26,7 @@ Feature: Users management as admin
 
   Scenario: Search and delete a user
     Given I am a platform administrator
+    And Admin top bar is disabled
     And I am on "/main/admin/user_list.php"
     And I fill in "keyword" with "smarshall"
     And I press "submit"