Group: #fix random user assignation to group and only students no teacher - refs BT#23012

Author: NicoDucou

main/inc/lib/groupmanager.lib.php

@@ -1427,9 +1427,16 @@ public static function fillGroupWithUsers($groupInfo)
             return false;
         }
         $session_id = api_get_session_id();
+        $studentStatus = 5;
+        if (isset($session_id) && $session_id != 0) {
+            $studentStatus = 0;
+        }
         $complete_user_list = CourseManager::get_user_list_from_course_code(
             $_course['code'],
-            $session_id
+            $session_id,
+            null,
+            null,
+            $studentStatus
         );
         $groupIid = $groupInfo['iid'];
         $category = self::get_category_from_group($groupIid);
@@ -1448,6 +1455,7 @@ public static function fillGroupWithUsers($groupInfo)
         }
 
         $usersToAdd = [];
+        shuffle($complete_user_list);
         foreach ($complete_user_list as $userInfo) {
             $isSubscribed = self::is_subscribed($userInfo['user_id'], $groupInfo);
             if ($isSubscribed) {