fix: Don't send statistics from a platform other than Android

Author: Hocuri

src/context.rs

@@ -14,7 +14,6 @@ use ratelimit::Ratelimit;
 use tokio::sync::{Mutex, Notify, RwLock};
 
 use crate::chat::{ChatId, get_chat_cnt};
-use crate::chatlist_events;
 use crate::config::Config;
 use crate::constants::{self, DC_BACKGROUND_FETCH_QUOTA_CHECK_RATELIMIT, DC_VERSION_STR};
 use crate::contact::{Contact, ContactId};
@@ -34,6 +33,7 @@ use crate::sql::Sql;
 use crate::stock_str::StockStrings;
 use crate::timesmearing::SmearedTimestamp;
 use crate::tools::{self, duration_to_str, time, time_elapsed};
+use crate::{chatlist_events, statistics};
 
 /// Builder for the [`Context`].
 ///
@@ -1079,9 +1079,7 @@ impl Context {
         );
         res.insert(
             "send_statistics",
-            self.get_config_bool(Config::SendStatistics)
-                .await?
-                .to_string(),
+            statistics::should_send_statistics(self).await?.to_string(),
         );
         res.insert(
             "last_statistics_sent",

src/statistics.rs

@@ -144,7 +144,7 @@ struct JoinedInvite {
 /// On the other end, a bot will receive the message and make it available
 /// to Delta Chat's developers.
 pub async fn maybe_send_statistics(context: &Context) -> Result<Option<ChatId>> {
-    if context.get_config_bool(Config::SendStatistics).await? {
+    if should_send_statistics(context).await? {
         let last_sending_time = context.get_config_i64(Config::LastStatisticsSent).await?;
         let next_sending_time = last_sending_time.saturating_add(30); // TODO increase to 1 day or 1 week
         if next_sending_time <= time() {
@@ -154,6 +154,21 @@ pub async fn maybe_send_statistics(context: &Context) -> Result<Option<ChatId>>
     Ok(None)
 }
 
+pub(crate) async fn should_send_statistics(_context: &Context) -> Result<bool> {
+    #[cfg(any(target_os = "android", test))]
+    {
+        _context.get_config_bool(Config::SendStatistics).await
+    }
+
+    // If the user enables statistics-sending on Android,
+    // and then transfers the account to e.g. Desktop,
+    // we should not send any statistics:
+    #[cfg(not(any(target_os = "android", test)))]
+    {
+        Ok(false)
+    }
+}
+
 async fn send_statistics(context: &Context) -> Result<ChatId> {
     info!(context, "Sending statistics.");
 
@@ -584,7 +599,7 @@ pub(crate) async fn count_securejoin_ux_info(
     source: Option<u32>,
     uipath: Option<u32>,
 ) -> Result<()> {
-    if !context.get_config_bool(Config::SendStatistics).await? {
+    if !should_send_statistics(context).await? {
         return Ok(());
     }
 
@@ -669,7 +684,7 @@ async fn get_securejoin_uipath_stats(context: &Context) -> Result<SecurejoinUIPa
 }
 
 pub(crate) async fn count_securejoin_invite(context: &Context, invite: &QrInvite) -> Result<()> {
-    if !context.get_config_bool(Config::SendStatistics).await? {
+    if !should_send_statistics(context).await? {
         return Ok(());
     }