api!(jsonrpc): chat_type now contains a variant of a string enum/union. Affected places: FullChat.chat_type, BasicChat.chat_type, ChatListItemFetchResult::ChatListItem.chat_type, Event:: SecurejoinInviterProgress.chat_type and MessageSearchResult.chat_type
#7285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2025
Closed
iequidoo
changed the title
chat_type now contains a variant of a string enum/union. Affected places: FullChat.chat_type, BasicChat.chat_type, ChatListItemFetchResult::ChatListItem.chat_type, Event:: SecurejoinInviterProgress.chat_type and MessageSearchResult.chat_typechat_type now contains a variant of a string enum/union. Affected places: FullChat.chat_type, BasicChat.chat_type, ChatListItemFetchResult::ChatListItem.chat_type, Event:: SecurejoinInviterProgress.chat_type and MessageSearchResult.chat_type
iequidoo
reviewed
Oct 20, 2025
Collaborator
|
Note that merging this will have to wait until we UIs can safely update core again (i.e. at least until #7326 is merged, better until we have another core release from main). Otherwise, building Desktop main with core main will fail for an extended period of time. |
iequidoo
approved these changes
Oct 21, 2025
Open
3 tasks
link2xt
approved these changes
Nov 4, 2025
Collaborator
link2xt
left a comment
link2xt
left a comment
There was a problem hiding this comment.
This can be merged now, it will go into 2.25.0 then. UIs will have to adapt, but it is doable.
enum/union. Affected places: `FullChat.chat_type`, `BasicChat.chat_type`, `ChatListItemFetchResult::ChatListItem.chat_type`, `Event:: SecurejoinInviterProgress.chat_type` and `MessageSearchResult.chat_type`
Simon-Laux
force-pushed
the
simon/i7029-jsonrpc-string-union-for-chat-type
branch
from
e099e36 to
a58cc42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying the breaking change.
Actually it will be not as breaking if you used the constants, because this pr will also change the constants.
chat_typenow contains a variant of a string enum/union. Affected places:FullChat.chat_type,BasicChat.chat_type,ChatListItemFetchResult::ChatListItem.chat_type,Event:: SecurejoinInviterProgress.chat_typeandMessageSearchResult.chat_type#7285investigate and fix python testslooks like this was simply CI failure (missing deltachat-rpc-server artifact), I just restarted it, let's see...closes #7029
Note that I had to change the constants from enum to namespace, this has the side effect, that you can no longer also use the constants as types, you need to instead prefix them with
typeofnow.