-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Description
Description
When switching to the t > 2 filter for signal selection, the old rbar_ok filter should be removed from the codebase as it will no longer be needed.
Context
The codebase currently uses an rbar_ok filter defined in 1_Download_and_Clean.R:135 that filters signals based on rbar > 0.15. This filter is used in multiple places:
- 3c_DataCounts.R: Lines 12, 32, 94, 129-140 for filtering signals
- 1_Download_and_Clean.R: Line 135-136 for defining the filter
With the adoption of the t > 2 filter (as seen in 4c1_ResearchVsDMprep.R:99 and 4c3_ResearchVsAcctVsTicker.R), the rbar_ok filter becomes redundant.
Tasks
- Remove rbar_ok filter definition from 1_Download_and_Clean.R
- Update all filtering logic in 3c_DataCounts.R to use t > 2 filter instead
- Update any dependent analyses that rely on rbar_ok
- Verify that all signal selection uses consistent t > 2 threshold
- Update documentation to reflect the new filtering approach
Files to Update
- 1_Download_and_Clean.R
- 3c_DataCounts.R
- Any other files using rbar_ok filter
Additional Notes
This change is part of the transition to using statistical significance (t > 2) as the primary filter for signal selection, which is more robust than the previous rbar threshold approach.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels