From cf4d4ef78c6dc26c3182644214ddcf396ec275db Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 27 Jan 2026 13:49:07 +0000 Subject: [PATCH 1/5] Initial plan From 0ecac85d217dbfe2254d9d407eefbbce8e592899 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 27 Jan 2026 13:57:49 +0000 Subject: [PATCH 2/5] Add deep cloning for opacities map in clone method Co-authored-by: chengcli <69489965+chengcli@users.noreply.github.com> --- src/radiation/radiation_band.hpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/radiation/radiation_band.hpp b/src/radiation/radiation_band.hpp index fb05e03..3b868dc 100644 --- a/src/radiation/radiation_band.hpp +++ b/src/radiation/radiation_band.hpp @@ -75,6 +75,13 @@ struct RadiationBandOptionsImpl { if (op->toon() != nullptr) { op->toon() = op->toon()->clone(); } + if (op->opacities().size() > 0) { + auto& opacities_ref = op->opacities(); + opacities_ref.clear(); + for (auto const& [k, v] : opacities()) { + opacities_ref[k] = v->clone(); + } + } return op; } void report(std::ostream& os) const { From 4bc769e912eccedee1d1ea7ed93e373a038e763a Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 27 Jan 2026 14:02:08 +0000 Subject: [PATCH 3/5] Final update: deep cloning implementation complete Co-authored-by: chengcli <69489965+chengcli@users.noreply.github.com> --- _codeql_detected_source_root | 1 + 1 file changed, 1 insertion(+) create mode 120000 _codeql_detected_source_root diff --git a/_codeql_detected_source_root b/_codeql_detected_source_root new file mode 120000 index 0000000..945c9b4 --- /dev/null +++ b/_codeql_detected_source_root @@ -0,0 +1 @@ +. \ No newline at end of file From f5305d5df834e60172d7bf5da08210d3b7a9ec91 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 27 Jan 2026 14:02:16 +0000 Subject: [PATCH 4/5] Remove CodeQL artifact file Co-authored-by: chengcli <69489965+chengcli@users.noreply.github.com> --- _codeql_detected_source_root | 1 - 1 file changed, 1 deletion(-) delete mode 120000 _codeql_detected_source_root diff --git a/_codeql_detected_source_root b/_codeql_detected_source_root deleted file mode 120000 index 945c9b4..0000000 --- a/_codeql_detected_source_root +++ /dev/null @@ -1 +0,0 @@ -. \ No newline at end of file From a1abd96c6cbc37614fec11d7394b10b576fad59c Mon Sep 17 00:00:00 2001 From: Cheng Li <69489965+chengcli@users.noreply.github.com> Date: Tue, 27 Jan 2026 11:10:12 -0500 Subject: [PATCH 5/5] Update src/radiation/radiation_band.hpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- src/radiation/radiation_band.hpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/radiation/radiation_band.hpp b/src/radiation/radiation_band.hpp index 3b868dc..142bde0 100644 --- a/src/radiation/radiation_band.hpp +++ b/src/radiation/radiation_band.hpp @@ -75,12 +75,10 @@ struct RadiationBandOptionsImpl { if (op->toon() != nullptr) { op->toon() = op->toon()->clone(); } - if (op->opacities().size() > 0) { - auto& opacities_ref = op->opacities(); - opacities_ref.clear(); - for (auto const& [k, v] : opacities()) { - opacities_ref[k] = v->clone(); - } + auto& opacities_ref = op->opacities(); + opacities_ref.clear(); + for (auto const& [k, v] : opacities()) { + opacities_ref[k] = v->clone(); } return op; }