Skip to content

Bugfix/cannot display on console #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
realJackSun wants to merge 3 commits into
base: feature_support_grpc
Choose a base branch
from
Open

Bugfix/cannot display on console #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a0ecd2
注意点1：AbsractNamingRequest成员变量必须为公有化成员,并驼峰命名法
realJackSun Sep 2, 2021
123fec7
namespace要么为空，要么必须已经在远程存在，否则注册的时候会被NamespaceRequestFilter 直接 pass掉，返回…
realJackSun Sep 2, 2021
fc7c632
ConnectionSetupRequest中的字段也要修改
realJackSun Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions v2/nacos/remote/requests/abstract_naming_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,30 @@


class AbstractNamingRequest(Request, metaclass=ABCMeta):
def __init__(self, namespace: str, service_name: str, group_name: str):
def __init__(self, namespace: str, serviceName: str, groupName: str):
super().__init__()
self.__MODULE = "naming"
self.__namespace = namespace
self.__service_name = service_name
self.__group_name = group_name
self.namespace = namespace
self.serviceName = serviceName
self.groupName = groupName

def get_module(self):
return self.__MODULE

def get_namespace(self) -> str:
return self.__namespace
return self.namespace

def set_namespace(self, namespace: str) -> None:
self.__namespace = namespace
self.namespace = namespace

def get_service_name(self) -> str:
return self.__service_name
return self.serviceName

def set_service_name(self, service_name: str) -> None:
self.__service_name = service_name
def set_service_name(self, serviceName: str) -> None:
self.serviceName = serviceName

def get_group_name(self) -> str:
return self.__group_name
return self.groupName

def set_group_name(self, group_name: str) -> None:
self.__group_name = group_name
def set_group_name(self, groupName: str) -> None:
self.groupName = groupName
36 changes: 18 additions & 18 deletions v2/nacos/remote/requests/connection_setup_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,42 +5,42 @@


class ConnectionSetupRequest(request.Request):
def __init__(self):
super().__init__()
self.__client_version = ""
self.__client_abilities = None
self.__abilities = ClientAbilities()
self.__tenant = ""
self.__labels = {}
def init(self):
super().init()
self.clientVersion = ""
self.clientAbilities = None
self.abilities = ClientAbilities()
self.tenant = ""
self.labels = {}

self.__MODULE = "internal"
self.MODULE = "internal"

def get_client_version(self) -> str:
return self.__client_version
return self.clientVersion

def set_client_version(self, client_version: str) -> None:
self.__client_version = client_version
def set_client_version(self, clientVersion: str) -> None:
self.clientVersion = clientVersion

def get_labels(self) -> Dict[str, str]:
return self.__labels
return self.labels

def set_labels(self, labels: Dict[str, str]) -> None:
self.__labels = labels
self.labels = labels

def get_tenant(self) -> str:
return self.__tenant
return self.tenant

def set_tenant(self, tenant: str) -> None:
self.__tenant = tenant
self.tenant = tenant

def get_abilities(self) -> ClientAbilities:
return self.__abilities
return self.abilities

def set_abilities(self, abilities: ClientAbilities) -> None:
self.__abilities = abilities
self.abilities = abilities

def get_module(self):
return self.__MODULE
return self.MODULE

def get_remote_type(self):
return remote_request_type["ConnectionSetup"]
6 changes: 3 additions & 3 deletions z-test-sdk/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import sys

SERVER_ADDRESSES = "http://mse-96d50180-p.nacos-ans.mse.aliyuncs.com:8848"
NAMESPACE = "test"
NAMESPACE = "public"

if __name__ == '__main__':
properties = {
Expand All @@ -25,5 +25,5 @@
logger.setLevel(logging.DEBUG)

naming = NacosNamingService(logger, properties)
# naming.register_instance("nacos.test.3", "default", "11.11.11.11", 8888, "default")
# print("step:2")
naming.register_instance("nacos.test.3", "default", "11.11.11.11", 8888, "default")
print("step:2")