From ddc4119722ddc5f4062d58fe5a7cde6bc3b50e44 Mon Sep 17 00:00:00 2001 From: Jinesh Francis Date: Wed, 20 Oct 2021 10:56:42 +0530 Subject: [PATCH 1/5] Added callback with null error to notify if a mail is send for android --- android/src/main/java/com/chirag/RNMail/RNMailModule.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/android/src/main/java/com/chirag/RNMail/RNMailModule.java b/android/src/main/java/com/chirag/RNMail/RNMailModule.java index e93973e..6792b53 100644 --- a/android/src/main/java/com/chirag/RNMail/RNMailModule.java +++ b/android/src/main/java/com/chirag/RNMail/RNMailModule.java @@ -136,6 +136,7 @@ public void mail(ReadableMap options, Callback callback) { i.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); try { reactContext.startActivity(i); + callback.invoke(null); } catch (Exception ex) { callback.invoke("error"); } @@ -151,6 +152,7 @@ public void mail(ReadableMap options, Callback callback) { try { reactContext.startActivity(chooser); + callback.invoke(null); } catch (Exception ex) { callback.invoke("error"); } From f6e548daf604aa962e5d92e3d47575095d1b295a Mon Sep 17 00:00:00 2001 From: Jinesh Francis Date: Wed, 20 Oct 2021 11:09:59 +0530 Subject: [PATCH 2/5] Updated callback to pass nothing in case of success --- android/src/main/java/com/chirag/RNMail/RNMailModule.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/src/main/java/com/chirag/RNMail/RNMailModule.java b/android/src/main/java/com/chirag/RNMail/RNMailModule.java index 6792b53..6148b31 100644 --- a/android/src/main/java/com/chirag/RNMail/RNMailModule.java +++ b/android/src/main/java/com/chirag/RNMail/RNMailModule.java @@ -136,7 +136,7 @@ public void mail(ReadableMap options, Callback callback) { i.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); try { reactContext.startActivity(i); - callback.invoke(null); + callback.invoke(); } catch (Exception ex) { callback.invoke("error"); } @@ -152,7 +152,7 @@ public void mail(ReadableMap options, Callback callback) { try { reactContext.startActivity(chooser); - callback.invoke(null); + callback.invoke(); } catch (Exception ex) { callback.invoke("error"); } From 43dd21d95b48352336f409e404a23aa5e9fa9429 Mon Sep 17 00:00:00 2001 From: Jinesh Francis Date: Wed, 20 Oct 2021 11:16:50 +0530 Subject: [PATCH 3/5] Added success callback --- android/src/main/java/com/chirag/RNMail/RNMailModule.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/src/main/java/com/chirag/RNMail/RNMailModule.java b/android/src/main/java/com/chirag/RNMail/RNMailModule.java index 6148b31..ba1b097 100644 --- a/android/src/main/java/com/chirag/RNMail/RNMailModule.java +++ b/android/src/main/java/com/chirag/RNMail/RNMailModule.java @@ -136,7 +136,7 @@ public void mail(ReadableMap options, Callback callback) { i.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); try { reactContext.startActivity(i); - callback.invoke(); + callback.invoke("success"); } catch (Exception ex) { callback.invoke("error"); } @@ -152,7 +152,7 @@ public void mail(ReadableMap options, Callback callback) { try { reactContext.startActivity(chooser); - callback.invoke(); + callback.invoke("success"); } catch (Exception ex) { callback.invoke("error"); } From 9defd56259f04c2c6c8d0df4783cc279a4a57454 Mon Sep 17 00:00:00 2001 From: Jinesh Francis Date: Wed, 20 Oct 2021 11:25:12 +0530 Subject: [PATCH 4/5] Update RNMailModule.java Working fine with empty callback --- android/src/main/java/com/chirag/RNMail/RNMailModule.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/src/main/java/com/chirag/RNMail/RNMailModule.java b/android/src/main/java/com/chirag/RNMail/RNMailModule.java index ba1b097..6148b31 100644 --- a/android/src/main/java/com/chirag/RNMail/RNMailModule.java +++ b/android/src/main/java/com/chirag/RNMail/RNMailModule.java @@ -136,7 +136,7 @@ public void mail(ReadableMap options, Callback callback) { i.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); try { reactContext.startActivity(i); - callback.invoke("success"); + callback.invoke(); } catch (Exception ex) { callback.invoke("error"); } @@ -152,7 +152,7 @@ public void mail(ReadableMap options, Callback callback) { try { reactContext.startActivity(chooser); - callback.invoke("success"); + callback.invoke(); } catch (Exception ex) { callback.invoke("error"); } From fa11523b28c9bda87b4f3258e4a6797b2ec64480 Mon Sep 17 00:00:00 2001 From: Jinesh Francis Date: Thu, 15 Dec 2022 13:19:18 +0530 Subject: [PATCH 5/5] Fixed gmail resolve bug of Android 13 --- android/src/main/java/com/chirag/RNMail/RNMailModule.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/android/src/main/java/com/chirag/RNMail/RNMailModule.java b/android/src/main/java/com/chirag/RNMail/RNMailModule.java index 6148b31..59bee66 100644 --- a/android/src/main/java/com/chirag/RNMail/RNMailModule.java +++ b/android/src/main/java/com/chirag/RNMail/RNMailModule.java @@ -18,6 +18,7 @@ import java.io.File; import java.net.URI; import java.util.ArrayList; +import android.os.Build; /** * NativeModule that allows JS to open emails sending apps chooser. @@ -127,7 +128,7 @@ public void mail(ReadableMap options, Callback callback) { PackageManager manager = reactContext.getPackageManager(); List list = manager.queryIntentActivities(i, 0); - if (list == null || list.size() == 0) { + if ((list == null || list.size() == 0) && Build.VERSION.SDK_INT < 33) { callback.invoke("not_available"); return; }