Merge branch 'main' of github.com:chobble-mirror/esp32-web-form-trigger

Author: stefan-burke

app/controllers/concerns/submission_processing.rb

@@ -87,4 +87,4 @@ def submission_params
       {}
     end
   end
-end
+end

spec/migrations/ensure_form_codes_spec.rb

@@ -55,4 +55,4 @@ def create_form_without_code(attrs = {})
     form3.reload
     expect(form3.code).to eq(original_code)
   end
-end
+end

spec/models/form_spec.rb

@@ -53,47 +53,47 @@
         button_text: "Submit",
         code: "ABCDEFGHIJKL"
       )
-      
+
       form.name = "Updated Form"
       form.save!
-      
+
       expect(form.reload.code).to eq("ABCDEFGHIJKL")
     end
 
     it "ensures uniqueness of codes" do
-      existing_form = Form.create!(
+      Form.create!(
         name: "Existing Form",
         button_text: "Submit",
         code: "ABCDEFGHIJKL"
       )
-      
+
       new_form = Form.new(
         name: "New Form",
         button_text: "Submit",
         code: "ABCDEFGHIJKL"
       )
-      
+
       expect(new_form).not_to be_valid
       expect(new_form.errors[:code]).to include("has already been taken")
     end
   end
 
   describe ".find_by_code_or_id" do
     let!(:form) { Form.create!(name: "Test Form", button_text: "Submit") }
-    
+
     it "finds a form by its code" do
       found_form = Form.find_by_code_or_id(form.code)
       expect(found_form).to eq(form)
     end
-    
+
     it "finds a form by its ID" do
       found_form = Form.find_by_code_or_id(form.id)
       expect(found_form).to eq(form)
     end
-    
+
     it "returns nil when neither code nor ID matches" do
       found_form = Form.find_by_code_or_id("NONEXISTENT")
       expect(found_form).to be_nil
     end
   end
-end
+end

spec/requests/empty_form_submissions_spec.rb

@@ -2,7 +2,7 @@
 
 RSpec.describe "Empty form submissions", type: :request do
   let!(:device) { Device.create!(name: "Test Device", location: "Test Location") }
-  
+
   describe "form with no enabled fields" do
     let!(:form) do
       Form.create!(
@@ -15,18 +15,18 @@
         enable_postcode: false
       )
     end
-    
+
     it "allows submitting a form with no fields" do
       expect {
         post public_form_path(form.code, device.id)
       }.to change(Submission, :count).by(1)
-      
+
       expect(response).to redirect_to(form_thanks_path(form.code, device))
       follow_redirect!
       expect(response).to have_http_status(:success)
     end
   end
-  
+
   describe "code with no enabled fields" do
     let!(:form) do
       Form.create!(
@@ -39,21 +39,21 @@
         enable_postcode: false
       )
     end
-    
+
     let!(:code) { Code.create!(device: device, form: form) }
-    
+
     it "allows submitting a code form with no fields" do
       expect {
         post public_code_path(code)
       }.to change(Submission, :count).by(1)
-      
+
       expect(response).to redirect_to(code_thanks_path(code))
       follow_redirect!
       expect(response).to have_http_status(:success)
-      
+
       # Verify the code was claimed
       code.reload
       expect(code.claimed?).to be true
     end
   end
-end
+end

spec/requests/public_forms_code_handling_spec.rb

@@ -63,7 +63,7 @@
 
     it "renders correctly in the forms edit view" do
       # Log in as admin to access the forms
-      admin = login_as_admin
+      login_as_admin
 
       # Link the form to the device
       form.devices << device
@@ -75,4 +75,4 @@
       expect(response.body).to include(public_form_path(form.code, device.id))
     end
   end
-end
+end