(#64) Allow service to be configured for non-Windows.

Check the service state rather than PID for non-Windows
This allows for the continued checking of 'puppet' service but also allows checking other service names like 'puppet-run.service' used by The Foreman module for Puppet.
This change is backwards incompatible due to the change in configuration key

Fixes #64

Author: treydock

README.md

@@ -37,7 +37,7 @@ mcollective_agent_puppet::config:
   command: "puppet agent"
   splay: true
   splaylimit: 30
-  windows_service: puppet
+  service: puppet
   signal_daemon: true
 ```
 
@@ -73,14 +73,14 @@ mcollective_agent_puppet::config:
 If you supply the value *none* to *type_whitelist* it will have the effect of denying
 all resource management - this is the default.
 
-On Windows, the name of the Puppet service is needed to determine if the
+The name of the Puppet service is needed to determine if the
 service is running. The service name varies between Puppet open source and
 Puppet Enterprise (puppet vs. pe-puppet); the default is puppet, but it can be
 explicitly specified:
 
 ```yaml
 mcollective_agent_puppet::config:
-  windows_service: puppet
+  service: puppet
 ```
 
 The agent will by default invoke `command` to initiate a

agent/puppet.rb

@@ -10,7 +10,7 @@ def startup_hook
         configfile = @config.pluginconf.fetch("puppet.config", nil)
 
         @puppet_command = @config.pluginconf.fetch("puppet.command", default_agent_command)
-        @puppet_service = @config.pluginconf.fetch("puppet.windows_service", "puppet")
+        @puppet_service = @config.pluginconf.fetch("puppet.service", "puppet")
         @puppet_splaylimit = Integer(@config.pluginconf.fetch("puppet.splaylimit", 30))
         @puppet_splay = Util.str_to_bool(@config.pluginconf.fetch("puppet.splay", "true"))
         @puppet_agent = Util::PuppetAgentMgr.manager(configfile, @puppet_service)

spec/agent/puppet_agent_spec.rb

@@ -27,7 +27,7 @@
 
     it "should set the service name based on the config" do
       MCollective::Config.instance.stubs(:pluginconf).returns(
-        {"puppet.windows_service" => "not-puppet"})
+        {"puppet.service" => "not-puppet"})
       MCollective::Util::PuppetAgentMgr.expects(:manager).with(nil, "not-puppet")
 
       @agent.startup_hook

spec/util/puppet_agent_mgr/mgr_v3_spec.rb

@@ -15,15 +15,20 @@ module MCollective::Util
     end
 
     describe "#daemon_present?" do
-      it "should return false if the pidfile does not exist" do
-        File.expects(:exist?).with("pidfile").returns(false)
+      before :each do
+        @type = mock; @service = mock; @provider = mock
+        @service.stubs(:provider).returns(@provider)
+        @type.stubs(:new).returns(@service)
+        Puppet::Type.stubs(:type).returns(@type)
+      end
+
+      it "should return false if the service is not running" do
+        @provider.stubs(:status).returns(:stopped)
         @manager.daemon_present?.should == false
       end
 
-      it "should check the pid if the pidfile exist" do
-        File.expects(:exist?).with("pidfile").returns(true)
-        File.expects(:read).with("pidfile").returns(1)
-        @manager.expects(:has_process_for_pid?).with(1).returns(true)
+      it "should return true if the service is running" do
+        @provider.stubs(:status).returns(:running)
         @manager.daemon_present?.should == true
       end
     end

util/puppet_agent_mgr/mgr_v3.rb

@@ -58,6 +58,13 @@ def disabled?
           File.exist?(Puppet[:agent_disabled_lockfile])
         end
 
+        # is the agent daemon currently running?
+        def daemon_present?
+          service = ::Puppet::Type.type(:service).new(name: @puppet_service)
+          status = service.provider.status
+          status.to_s == 'running'
+        end
+
         private
 
         def platform_applying?