(#64) Allow service to be configured for non-Windows.

Check the service state rather than PID for non-Windows
This allows for the continued checking of 'puppet' service but also allows checking other service names like 'puppet-run.service' used by The Foreman module for Puppet.
This change is backwards incompatible due to the change in configuration key

Fixes #64

Author: treydock

README.md

@@ -37,7 +37,7 @@ mcollective_agent_puppet::config:
   command: "puppet agent"
   splay: true
   splaylimit: 30
-  windows_service: puppet
+  service: puppet
   signal_daemon: true
 ```
 
@@ -73,14 +73,14 @@ mcollective_agent_puppet::config:
 If you supply the value *none* to *type_whitelist* it will have the effect of denying
 all resource management - this is the default.
 
-On Windows, the name of the Puppet service is needed to determine if the
+The name of the Puppet service is needed to determine if the
 service is running. The service name varies between Puppet open source and
 Puppet Enterprise (puppet vs. pe-puppet); the default is puppet, but it can be
 explicitly specified:
 
 ```yaml
 mcollective_agent_puppet::config:
-  windows_service: puppet
+  service: puppet
 ```
 
 The agent will by default invoke `command` to initiate a

agent/puppet.rb

@@ -10,7 +10,7 @@ def startup_hook
         configfile = @config.pluginconf.fetch("puppet.config", nil)
 
         @puppet_command = @config.pluginconf.fetch("puppet.command", default_agent_command)
-        @puppet_service = @config.pluginconf.fetch("puppet.windows_service", "puppet")
+        @puppet_service = @config.pluginconf.fetch("puppet.service", "puppet")
         @puppet_splaylimit = Integer(@config.pluginconf.fetch("puppet.splaylimit", 30))
         @puppet_splay = Util.str_to_bool(@config.pluginconf.fetch("puppet.splay", "true"))
         @puppet_agent = Util::PuppetAgentMgr.manager(configfile, @puppet_service)

util/puppet_agent_mgr/mgr_v3.rb

@@ -58,6 +58,13 @@ def disabled?
           File.exist?(Puppet[:agent_disabled_lockfile])
         end
 
+        # is the agent daemon currently running?
+        def daemon_present?
+          service = Puppet::Type.type(:service).newservice(name: @puppet_service)
+          status = service.provider.status
+          status.to_s == 'running'
+        end
+
         private
 
         def platform_applying?