Fix for 10.5

.github/workflows/pythonapp.yml

@@ -0,0 +1,37 @@
+# This workflow will install Python dependencies, run tests and lint with a single version of Python
+# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
+
+name: Python application
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: [3.5, 3.6]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v1
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        # TODO: Add requirements.txt instead
+        pip install PyMySQL
+    - name: Lint with flake8
+      run: |
+        pip install flake8
+        # stop the build if there are Python syntax errors or undefined names
+        flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+        flake8 . --count --exit-zero --max-complexity=19 --max-line-length=127 --statistics

.gitignore

@@ -0,0 +1 @@
+/.vscode

README.md

@@ -6,7 +6,7 @@ Pulls most of the same metrics as the Percona Monitoring Plugins for Cacti. Coll
 
 Most MySQL monitoring plugins fetch a lot of information by parsing the output of `SHOW ENGINE INNODB STATUS`. This plugin prefers InnoDB statistics from `SHOW GLOBAL STATUS`. Percona Server and MariaDB provide most of these InnoDB metrics on `SHOW GLOBAL STATUS`.
 
-Requires the Python MySQLdb package. (`python-mysqldb` on Debian)
+Requires the Python `pymysql` package.
 
 ## Installation
 1. Place mysql.py in your CollectD python plugins directory
@@ -187,6 +187,7 @@ Collected from `SHOW VARIABLES`:
     variables.thread_cache_size
     variables.thread_concurrency
     variables.tmp_table_size
+    variables.read_only
 
 ### MySQL Processes
 
@@ -296,6 +297,30 @@ TBD:
 	hash_index_cells_used
 	additional_pool_alloc
 
+### InnoDB metrics from information_schema
+
+**Warning: This is only available in MariaDB >= 10.x and MySQL >= 5.6.**
+
+Collected by parsing the output of `SELECT COUNT from INFORMATION_SCHEMA.INNODB_METRICS where name ='os_log_bytes_written';`:
+
+    mysql plugin: Sending value: innodb/os_log_bytes_written=263167952896
+
+To get the metadata lock information:
+
+    mysql plugin: Sending value: innodb/lock=0
+
+- MariaDB: https://mariadb.com/kb/en/metadata-lock-info-plugin/
+- MySQL: https://dev.mysql.com/doc/refman/5.7/en/metadata-locks-table.html
+
+
+### Database size
+
+Collected by parsing the output of `SELECT table_schema 'db_name',  Round(Sum(data_length + index_length) / 1024 / 1024, 0) 'db_size_mb'  FROM   information_schema.tables WHERE table_schema not in ('mysql', 'information_schema', 'performance_schema', 'heartbeat') GROUP  BY table_schema;`:
+
+    db_size/databasename=14907
+
+The Database size is in MB.
+
 
 ### Master/Slave Status
 
@@ -310,6 +335,13 @@ From `SHOW SLAVE STATUS`:
     slave.slave_stopped - 1 when the slave is stopped, 0 when it's running
     slave.slave_running - 1 when the slave is running, 0 when it's stopped
 
+### Current connections for users
+
+This is using performance_schema. If performance_schema is not enabled, it won't work.
+
+    user_connection.root
+    user_connection.user-repl
+
 ### Query Response Times
 
 For versions of MySQL with support for it and where enabled, `INFORMATION_SCHEMA.QUERY_RESPONSE_TIME` will be queried for metrics to generate a histogram of query response times.