Skip to content

Conversation

@chrisirhc
Copy link
Owner

@chrisirhc chrisirhc commented May 18, 2020

styled-components alternative for comparison with #1.

Some notes:

@chrisirhc
Copy link
Owner Author

@mcnuttandrew
Copy link

Very cool! I like that there's a zero configuration change. Given how many issues on react-vis were basically just people forgetting to import the css file, I really like the idea of just being able to drop in a replacement.

I suspect it will also play nicer with both potential community contributors as well as potential react-vis users, as styled-components is quite a bit more popular than styletron (https://npmcharts.com/compare/styletron-react,styled-components). (not trying to dunk on styletron, just trying to ease adoption as much as possible)

Also there already appears to have been some community interest in this idea (uber#825), but that never really got beyond the RFC!

If this approach will re-engage uber support with the project I think this approach is quite a bit stronger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants