Commit bc44641
committed
Code review snippets to address from @davidben
Also:
* sus_if_msvc for attributes should be sus_if_msvc_not_cl
* "language is msvc variant" vs "compiler is msvc"
* sus_if_gnuc_language
* test wrapping for each integer size, esp < 32bit
* not destroy nevervalue? since it's in a union can that be a
requirement on NeverValueTypes, and is C++ okay with constructing
an object in a place where one already exists and was not destroyed?1 parent 7147b8f commit bc44641
3 files changed
+48
-90
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
135 | 134 | | |
136 | 135 | | |
137 | 136 | | |
| |||
This file was deleted.
0 commit comments