-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Because
As inspected and proposed in clamsproject/mmif#228, current specification that allows "scoped" short annotation ID's not only makes writing code to identify annotations using identifiers, but also has a serious flaw. To mitigate the problem, we decided to first update existing getters and setters of annotation ID's in serialize package to use "long" form all the time.
Done when
mmif-python/mmif/serialize/annotation.py
Lines 160 to 166 in 281e2cd
| @property | |
| def id(self) -> str: | |
| return self.properties.id | |
| @id.setter | |
| def id(self, aid: str) -> None: | |
| self.properties.id = aid |
is updated to match long_id property, and all other parts of code that uses id or long_id property are updated accordingly.
Additional context
This proposed change will vastly break compatibility of the SDK to existing CLAMS app code, so we need a version marker that can mark this breakage. (#293 )
Metadata
Metadata
Assignees
Labels
Type
Projects
Status