[Bug] Race condition in task-store hydrate with cachedDeviceId

[samzong]

Problem

Module-level mutable variable cachedDeviceId creates a race condition when hydrate() is called concurrently. Multiple calls can overwrite each other's state.

Location

File: packages/core/src/stores/task-store.ts:95

Code:

let cachedDeviceId: string | null = null;

// In hydrate():
if (get().hydrated) return;
cachedDeviceId = await deps.getDeviceId();

Fix Approach

Use a hydration promise to ensure single execution:

let hydrationPromise: Promise<void> | null = null;

// In hydrate:
if (get().hydrated) return;
if (hydrationPromise) return hydrationPromise;

hydrationPromise = (async () => {
  cachedDeviceId = await deps.getDeviceId();
  // ... rest of hydration
})();

return hydrationPromise;

Or move cachedDeviceId into store state.

Verification

1. Run pnpm check — must pass
2. Test concurrent hydrate calls don't race

Context

• WG: Task & Session Core
• Priority: Low (good first issue)
• Estimated effort: 15-30 minutes

[github-actions]

Hi @samzong,
Thanks for opening an issue!
We will look into it as soon as possible.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.