Closing game window often just unpauses the game

[Perdu]

I'm running libTAS on i3wm. To close the game, I use the close window function, which either uses the WM_DELETE protocol, or kill the window.

Under circumstances that I still have to identify properly, this does not close the game, and instead unpauses it.

I'll update this issue when I have more information.

[Perdu]

Additional info as it just happened again: the game unpauses, and becomes unresponsive to other shortcuts (such as pausing again, reloading savestates etc.). I have to send the window close event again so that the window actually closes.

For some reason, this seems to happen when I've had libTAS opened in the background for a long period of time

[clementgallet]

The game being unpaused is deliberate. We need the game to process the window closing event and exit. In very early libtas versions, the game was not unpaused. This led to confusion among users, because closing the game window would do nothing, and you had to manually unpause the game to let it exit.

On several games, closing the game window causes a softlock during the game exit code, for example related to the game waiting for the audio thread to process samples. I didn't see often the game running wildly without processing the game closing event.

[Perdu]

Interesting. Would it solve the problem to hard kill the process after a delay?

[clementgallet]

Hard kill is already possible with the "Kill" button. I may prefer to let the user kill the process itself, in case it takes a while.