Blockquote elements error on rendering

[svdm]

Trying to render a blockquote throws an exception right now:

user> (markdown->clj-pdf "> This is a quote")
java.lang.IllegalArgumentException: No matching field found: getLiteral for class org.commonmark.node.BlockQuote

The issue is that the :default case of the render method relies on .getLiteral on the parsed element. This works fine for code blocks etc, but blockquotes are parsed differently by commonmark-java. For this case it creates a BlockQuote containing one or more Paragraph nodes. The BlockQuote node itself has no .getLiteral implementation, hence the error.

Something like this seems to work, but I'm not familiar enough with this lib and clj-pdf to be sure it's entirely the right approach:

(defmethod render :BlockQuote
  [pdf-config node]
  (->> node
       (render-children* pdf-config)
       (wrap-paragraph pdf-config node)))

It also has the downside of using a plain :paragraph, which makes it hard to style quotes.

[leontalbot]

Nice catch.

I guess this would work (untested):

Adapt default-pdf-config like so: {:quote {:style :italic :color [128 128 128]} ...}

Change render-derivals by removing :BlockQuote from :Literal.

Add this :BlockQuote render method:

(defmethod render :BlockQuote
  [pdf-config node]
  (->> node
       (render-children* pdf-config)
       (into [:paragraph (:quote pdf-config)])))

If this works for you, feel free to send a PR with new test and README adapted.

[svdm]

Thanks! That does the trick for my use case, so I've created PR #3 with those changes and some basic test/readme additions.