From d951af6a9bc4e890d8a74fc668b4d588ba923257 Mon Sep 17 00:00:00 2001 From: Steve Faulkner Date: Wed, 25 Feb 2026 12:39:38 -0600 Subject: [PATCH 1/2] Skip deploy previews for fork PRs that lack Cloudflare secrets Fork PRs don't have access to repository secrets (CLOUDFLARE_API_TOKEN, CLOUDFLARE_ACCOUNT_ID), so deploy/smoke-test/comment steps always fail. Add a fork detection condition to skip these steps gracefully. The build steps still run, so example builds are still validated for fork PRs. --- .github/workflows/deploy-examples.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/deploy-examples.yml b/.github/workflows/deploy-examples.yml index 95a59043..00482e67 100644 --- a/.github/workflows/deploy-examples.yml +++ b/.github/workflows/deploy-examples.yml @@ -76,7 +76,7 @@ jobs: command: deploy --config ${{ matrix.example.wrangler_config }} - name: Deploy Preview Version - if: github.event_name == 'pull_request' + if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository uses: cloudflare/wrangler-action@v3 with: apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }} @@ -96,14 +96,14 @@ jobs: run: ./scripts/smoke-test.sh - name: Smoke test (preview) - if: github.event_name == 'pull_request' + if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository run: ./scripts/smoke-test.sh --preview pr-${{ github.event.pull_request.number }} comment: name: Comment Preview URLs runs-on: ubuntu-latest needs: deploy - if: github.event_name == 'pull_request' + if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository permissions: pull-requests: write steps: From 2a42f98e1e203f719c5298b21ee1feaa18024d36 Mon Sep 17 00:00:00 2001 From: Steve Faulkner Date: Fri, 6 Mar 2026 18:12:37 -0600 Subject: [PATCH 2/2] docs: update CONTRIBUTING.md to reflect current review workflow and merge philosophy --- CONTRIBUTING.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 45529da8..77878d1f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -15,12 +15,13 @@ We use [OpenCode](https://opencode.ai) with Claude Opus 4.6, set to max thinking ## AI code review -When you open a PR, tag one of our AI reviewers in a comment: +Every PR goes through AI code review. When you open a PR, a contributor with write access will request a review from **BigBonk** (Claude Opus 4.6, max thinking mode). External contributors can't trigger this directly. -- **`/bonk`** — AI code review using Claude Opus 4.6 -- **`/bigbonk`** — Same model, max thinking mode. Use this for complex or large PRs. +Our process is to iterate on BigBonk's feedback until there are no unresolved comments. That doesn't mean you have to accept every suggestion verbatim, but we've found it to be very good at finding real problems and very useful for debugging this codebase. Expect multiple review rounds on larger PRs. -The reviewer will leave comments on your PR. You can respond to its comments and it will follow up. +**Our bias is towards merging.** This is a new project with known gaps, and we're trying to fill them as fast as possible. We want to get PRs in, not block them. If your contribution moves things forward, we'll work with you to get it landed. + +At a maintainer's discretion, we may push BigBonk's recommended changes directly into your PR and merge it, or we may create a new PR based on your work. When we do this, we always try to preserve the original author credit. If that ever doesn't happen, please let us know and we'll fix it. ## Debugging @@ -28,7 +29,7 @@ For browser-level debugging (verifying rendered output, client-side navigation, ## What to work on -Check the [open issues](https://github.com/cloudflare/vinext/issues). Issues labeled `post-launch` are known gaps we're planning to address. If you're looking to contribute, those are a good place to start. +Check the [open issues](https://github.com/cloudflare/vinext/issues). If you're looking to contribute, those are a good place to start. ## Project structure