Skip to content

Commit 2ce7ec9

Browse files
committed
pull upstream changes
1 parent d3b21d6 commit 2ce7ec9

File tree

7 files changed

+30
-40
lines changed

7 files changed

+30
-40
lines changed

packages/gorouter/spec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ files:
3535
- code.cloudfoundry.org/gorouter/handlers/*.go # gosub
3636
- code.cloudfoundry.org/gorouter/integration/*.go # gosub
3737
- code.cloudfoundry.org/gorouter/logger/*.go # gosub
38+
- code.cloudfoundry.org/gorouter/logadapter/*.go # gosub
3839
- code.cloudfoundry.org/gorouter/mbus/*.go # gosub
3940
- code.cloudfoundry.org/gorouter/mbus/fakes/*.go # gosub
4041
- code.cloudfoundry.org/gorouter/metrics/*.go # gosub

src/code.cloudfoundry.org/gorouter/cmd/gorouter/main.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"syscall"
1212
"time"
1313

14+
"code.cloudfoundry.org/gorouter/logadapter"
1415
"code.cloudfoundry.org/gorouter/metrics_prometheus"
1516

1617
"code.cloudfoundry.org/clock"
@@ -100,11 +101,8 @@ func main() {
100101
runtime.GOMAXPROCS(c.GoMaxProcs)
101102
}
102103

103-
// start the debugserver
104104
if c.DebugAddr != "" {
105-
// create a zapLevelSink that uses the logger
106-
sink := &zapLevelSink{logger: logger}
107-
// create a new debugserver with the address and the sink and run it
105+
sink := logadapter.NewZapLevelSink(logger)
108106
_, err = debugserver.Run(c.DebugAddr, sink)
109107
if err != nil {
110108
logger.Error("failed-to-start-debug-server", grlog.ErrAttr(err))

src/code.cloudfoundry.org/gorouter/integration/test_utils_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package integration
22

33
import (
44
"crypto/tls"
5-
// "io"
65
"os"
76
"os/exec"
87
"syscall"

src/code.cloudfoundry.org/gorouter/cmd/gorouter/adapter.go renamed to src/code.cloudfoundry.org/gorouter/logadapter/logadapter.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package main
1+
package logadapter
22

33
import (
44
grlog "code.cloudfoundry.org/gorouter/logger"
@@ -8,7 +8,6 @@ import (
88
"log/slog"
99
"os"
1010
"strings"
11-
"time"
1211
)
1312

1413
// zapLevelSink is a lager sink that uses a slog.Logger for logging.
@@ -20,6 +19,10 @@ type zapLevelSink struct {
2019
logger *slog.Logger
2120
}
2221

22+
func NewZapLevelSink(l *slog.Logger) *zapLevelSink {
23+
return &zapLevelSink{logger: l}
24+
}
25+
2326
func (z *zapLevelSink) Log(lf lager.LogFormat) {
2427
z.logger.Info("zapLevelSink Log()", slog.String("Zap Level Sink log invoked", lf.Message),
2528
slog.String("source", lf.Source))
@@ -88,10 +91,8 @@ func NewZapLoggerWithTimestamp() *zap.Logger {
8891
cfg.TimeKey = "timestamp"
8992
cfg.LevelKey = "log_level"
9093
cfg.MessageKey = "message"
91-
// time encoded as float64
92-
cfg.EncodeTime = func(t time.Time, enc zapcore.PrimitiveArrayEncoder) {
93-
enc.AppendFloat64(float64(t.UnixNano()) / 1e9)
94-
}
94+
// time encoded in RFC3339 format
95+
cfg.EncodeTime = zapcore.RFC3339TimeEncoder
9596
// Encode log level as int. zapcore.Level is 0-indexed,
9697
// so add 1 to the level to match the gorouter's expected level.
9798
cfg.EncodeLevel = func(l zapcore.Level, enc zapcore.PrimitiveArrayEncoder) {

src/code.cloudfoundry.org/vendor/code.cloudfoundry.org/debugserver/adapter.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/code.cloudfoundry.org/vendor/code.cloudfoundry.org/debugserver/cf_debug_server_testhelper.go

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/code.cloudfoundry.org/vendor/code.cloudfoundry.org/debugserver/server.go

Lines changed: 4 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)