feat(plugin-barman-cloud): add additional annotations to service account #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>
QuantumEnigmaa
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
bot
added
the
size:S
| labels: | ||
| {{- include "plugin-barman-cloud.labels" . | nindent 4 }} | ||
| {{- with .Values.commonAnnotations }} | ||
| {{- if or .Values.serviceAccount.additionalAnnotations .Values.commonAnnotations }} |
There was a problem hiding this comment.
I think going with Values.serviceAccount.annotations might be enough?
Contributor
Author
There was a problem hiding this comment.
No because someone might only want to add additionalAnnotations (i.e only to the service account) and not any common annotations to all resources.
There was a problem hiding this comment.
I meant in place of additionalAnnotations, not common :)
| {{- with .Values.commonAnnotations }} | ||
| {{- if or .Values.serviceAccount.additionalAnnotations .Values.commonAnnotations }} | ||
| annotations: | ||
| {{- with .Values.serviceAccount.additionalAnnotations }} |
There was a problem hiding this comment.
I would render the common on first and override with the SA specific ones
|
Hey @itay-grudev do you think you could take a look on your side? |
2 tasks
…tional-annotations-serviceaccount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility for a user to add additional annotations to the service account if it's created from the chart.
This is especially useful when using IRSA authentication on AWS kubernetes clusters as the user can add the annotation directly in the chart's values.