feat(plugin-barman-cloud): add possiblity to turn off securityContext on pod- and container level #740
+26
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the requirements of #673.
In an OpenShift environment, you usually do not want to set
runAsUserorrunAsGroupto something specific, instead it is chosen automatically by the cluster to a random value. Also, any other SecurityContext Values of the Pods will automatically be set to secure defaults (allowPrivilegeEscalation: falseetc.).It is therefore usually best to just not set it at all.
With this change,
containerSecurityContext.enabledandpodSecurityContext.enabledcan be set tofalseto stop rendering out these fields completely.In #673 it was proposed to just remove the
requiredsetting forrunAsUserorrunAsGroup. If this is considered preferred to my solution, I can adjust the PR accordingly.