Bug Report: testConnectivity.py Accepts Bad Trigger Links

[bdorney]

Brief summary of issue

Seems like testConnectivity.py is accepting bad trigger links for the CSC trigger link and not issuing a failure.

Types of issue

• Bug report (report an issue with the code)
• Feature request (request for change which adds functionality)

Expected Behavior

If trigger link status counters are nonzero it should fail and say the test did not pass:

Current Behavior

testConnectivity.py -c GE11-X-S-BARI-0008 --checkCSCTrigLink --detType=short -f1 --gemType=ge11 -n 50 --writePhases2File 2 5 0x10
...
...
====================
Step 3: Programming FPGA & Checking Trigger Links
====================
20 May 2019 10:11:25.777 [7f25bf86f740] INFO - wrappers::runCommandWithOutput <> - Executing command: ssh gemuser@gem-shelf02-amc05 sh -c "mpeek 0x6a000000"
Initial value to write: 1, register GEM_AMC.TTC.GENERATOR.ENABLE
Initial value to write: 1, register GEM_AMC.TTC.GENERATOR.SINGLE_HARD_RESET
Initial value to write: 1, register GEM_AMC.GEM_SYSTEM.CTRL.LINK_RESET
Initial value to write: 0, register GEM_AMC.TTC.GENERATOR.ENABLE
SCA Communication Status After FPGA Programming Attempts Is:
--=======================================--
-> GEM SYSTEM SCA INFORMATION
--=======================================--

READY             0x00000010
CRITICAL_ERROR    0x00000000
NOT_READY_CNT_OH00 0x00000001
NOT_READY_CNT_OH01 0x00000001
NOT_READY_CNT_OH02 0x00000001
NOT_READY_CNT_OH03 0x00000001
NOT_READY_CNT_OH04 0x00000002
NOT_READY_CNT_OH05 0x00000001
NOT_READY_CNT_OH06 0x00000001
NOT_READY_CNT_OH07 0x00000001
NOT_READY_CNT_OH08 0x00000001
NOT_READY_CNT_OH09 0x00000001
NOT_READY_CNT_OH10 0x00000001
NOT_READY_CNT_OH11 0x00000001
FPGA Communication Established
Checking trigger link status:
Reset trigger module on OH4
Initial value to write: 1, register GEM_AMC.OH.OH4.FPGA.TRIG.LINKS.RESET
Reseting trigger module on CTP7
Initial value to write: 1, register GEM_AMC.TRIGGER.CTRL.MODULE_RESET
--=======================================--
-> GEM SYSTEM TRIGGER LINK INFORMATION
--=======================================--

----------OH4----------
LINK0_MISSED_COMMA_CNT          0x0
LINK1_MISSED_COMMA_CNT          0x0
LINK0_OVERFLOW_CNT              0x0
LINK1_OVERFLOW_CNT              0x0
LINK0_UNDERFLOW_CNT             0x0
LINK1_UNDERFLOW_CNT             0x0
LINK0_SBIT_OVERFLOW_CNT         0x0
LINK1_SBIT_OVERFLOW_CNT         0x0
----------OH5----------
LINK0_MISSED_COMMA_CNT          0x0
LINK1_MISSED_COMMA_CNT          0x0
LINK0_OVERFLOW_CNT              0x0
LINK1_OVERFLOW_CNT              0x0
LINK0_UNDERFLOW_CNT             0x0
LINK1_UNDERFLOW_CNT             0x0
LINK0_SBIT_OVERFLOW_CNT         0xbfffffff4
LINK1_SBIT_OVERFLOW_CNT         0x0
Trigger link to OHs in mask: 0x10 is good
Trigger Link Successfully Established

Here the CSC trigger link is not good but the script accepts it.

Steps to Reproduce (for bugs)

1. See above command

Possible Solution (for bugs)

Unclear...investigation needed.

Context (for feature requests)

Could allow bad detectors to make it to P5.

Your Environment

• Version used: 65adac3
• Shell used: bash

[lpetre-ulb]

Has this issue ever been reproduced? If yes, it would deserve a fix.