Implement switch nodes for categorical decisions

[nsmith-]

Hi @nsmith-,

Thank you for your reply and sorry for a delayed response. I think new node type proposal sounds good. I'm proposing the name "Comparison" instead to be a bit consistent with CMSSW string parser, but we don't need to.

For the Filter node, maybe we can add operator option to use either logical and or logical or of the Comparison nodes. Since you can give both true_value and false_value, I think the name Switch node might be better.

class Comparison(Model):
    variable: str
    cmp: Literal[">", "<", ">=", "<=", "==", "!="]
    value: float

class Switch(Model):
    nodetype: Literal["filter"]
    inputs: List[str]
    selections: List[Comparison]
    operator: Literal["and", "or"]
    true_value: Content
    false_value: Content

Do you think you can implement these? Otherwise, I can also take a look and try to implement these as well.

Originally posted by @patinkaew in #268

[nsmith-]

One comment: I would make the nodetype name equal to the class name, so switch in this case. I like Filter too, so either way works.

[patinkaew]

Hi @nsmith-,

Thank you for restarting the discussion! Just to clarify, PR#309 was merged and in principle, one can use this new feature to fix JetID. However, do you still prefer to have Switch / Filter node here because JetID is actually not formula as discussed here?

If so, I'm a bit busy now but I can try to have a look to implement this in the coming weeks.

[nsmith-]

Yes I think long-term it would be good to have such a node