not all date_utils tests need metadata

Author: nmdefries

google_symptoms/tests/test_date_utils.py

@@ -4,9 +4,13 @@
 from freezegun import freeze_time
 from conftest import TEST_DIR, NEW_DATE
 
+import covidcast
+
 from delphi_utils.validator.utils import lag_converter
 from delphi_google_symptoms.constants import FULL_BKFILL_START_DATE
 from delphi_google_symptoms.date_utils import generate_query_dates, generate_num_export_days, generate_patch_dates
+
+
 class TestDateUtils:
 
     @freeze_time("2021-01-05")
@@ -36,31 +40,29 @@ def test_generate_query_dates_custom(self):
         assert set(output) == set(expected)
 
     def test_generate_export_dates(self, params, logger, monkeypatch):
-        import covidcast
         metadata_df = pd.read_csv(f"{TEST_DIR}/test_data/covid_metadata.csv")
         monkeypatch.setattr(covidcast, "metadata", lambda: metadata_df)
-        num_export_days = generate_num_export_days(params, logger)
 
+        num_export_days = generate_num_export_days(params, logger)
         expected_num_export_days = params["indicator"]["num_export_days"]
-
         assert num_export_days == expected_num_export_days
 
     def test_generate_export_dates_normal(self, params_w_no_date, logger, monkeypatch):
-        import covidcast
         metadata_df = pd.read_csv(f"{TEST_DIR}/test_data/covid_metadata.csv")
         monkeypatch.setattr(covidcast, "metadata", lambda: metadata_df)
+
         num_export_days = generate_num_export_days(params_w_no_date, logger)
 
-        max_expected_lag = lag_converter(params_w_no_date["validation"]["common"].get("max_expected_lag", {"all": 4}))
+        max_expected_lag = lag_converter(params_w_no_date["validation"]["common"]["max_expected_lag"])
         global_max_expected_lag = max(list(max_expected_lag.values()))
-        expected_num_export_days = params_w_no_date["validation"]["common"].get("span_length", 14) + global_max_expected_lag
+        expected_num_export_days = params_w_no_date["validation"]["common"]["span_length"] + global_max_expected_lag
 
         assert num_export_days == expected_num_export_days
 
     def test_generate_export_date_missing(self, params_w_no_date, logger, monkeypatch):
-        import covidcast
         metadata_df = pd.read_csv(f"{TEST_DIR}/test_data/covid_metadata_missing.csv")
         monkeypatch.setattr(covidcast, "metadata", lambda: metadata_df)
+
         num_export_days = generate_num_export_days(params_w_no_date, logger)
         expected_num_export_days = (date.today() - FULL_BKFILL_START_DATE.date()).days + 1
         assert num_export_days == expected_num_export_days
@@ -89,10 +91,7 @@ def generate_expected_start_end_dates(self, params_, issue_date):
             "export_end_date": max(dates[6:21])
         }
 
-    def test_generate_patch_dates(self, params_w_patch, logger, monkeypatch):
-        import covidcast
-        metadata_df = pd.read_csv(f"{TEST_DIR}/test_data/covid_metadata_missing.csv")
-        monkeypatch.setattr(covidcast, "metadata", lambda: metadata_df)
+    def test_generate_patch_dates(self, params_w_patch, logger):
         max_expected_lag = lag_converter(params_w_patch["validation"]["common"]["max_expected_lag"])
         global_max_expected_lag = max(list(max_expected_lag.values()))
         num_export_days = params_w_patch["validation"]["common"]["span_length"]