Merge pull request #326 from cmu-delphi/update-meta-check

Update R plotting metadata check

Author: capnrefsmmat

R-packages/covidcast/DESCRIPTION

@@ -60,3 +60,4 @@ Suggests:
     tibble,
     vdiffr
 VignetteBuilder: knitr
+Config/testthat/edition: 3

R-packages/covidcast/R/plot.R

@@ -110,7 +110,8 @@ plot.covidcast_signal = function(x, plot_type = c("choro", "bubble", "line"),
   # For the maps, set range, if we need to (to mean +/- 3 standard deviations,
   # from metadata) 
   if (is.null(range) && (plot_type == "choro" || plot_type == "bubble")) {
-    if (is.null(attributes(x)$metadata)) { 
+    if (is.null(attributes(x)$metadata$mean_value) || 
+        is.null(attributes(x)$metadata$stdev_value)) { 
       warn(paste("Metadata for signal mean and standard deviation not",
                  "available; defaulting to observed mean and standard",
                  "deviation to set plot range."),

R-packages/covidcast/tests/testthat/test-plot.R

@@ -116,3 +116,24 @@ test_that("simple county bubble plot", {
                       suppressWarnings(
                         plot(fb_county, plot_type = "bubble")))
 })
+
+
+test_that("warn on incomplete metadata", {
+  fake_data <- structure(data.frame(
+    data_source = "foo",
+    signal = "bar",
+    value = c(1, 2, 0, 3),
+    geo_value = c("pa", "in", "tx", "wy"),
+    time_value = as.Date("2020-01-01"),
+    issue = as.Date("2020-02-01"),
+    stderr = 0.5),
+    class = c("covidcast_signal", "data.frame"),
+    metadata = list(geo_type = "state", mean_value = 0, stdev_value = 1)
+  )
+  
+  expect_warning(plot(fake_data), NA) 
+  attributes(fake_data)$metadata = list(geo_type = "state", mean_value = 0)
+
+  expect_warning(plot(fake_data),
+                 class="covidcast_plot_meta_not_found")
+})