Merge pull request #237 from cmu-delphi/ndefries/int-addl-capacity

Parse int fields as double so large values don't get set to NA

Author: nmdefries

R/model.R

@@ -156,7 +156,19 @@ parse_value <- function(info, value, disable_date_parsing = FALSE) {
   } else if (info$type == "bool") {
     return(as.logical(value))
   } else if (info$type == "int") {
-    return(as.integer(value))
+    # Int doesn't have enough capacity to store some weekly `pub_wiki` values.
+    value <- as.double(value)
+    if (any(value != round(value))) {
+      cli::cli_warn(
+        c(
+          "Values in {info$name} were expected to be integers but contain a decimal component",
+          "i" = "Decimal components are returned as-is"
+        ),
+        class = "epidatr__int_nonzero_decimal_digits"
+      )
+    }
+
+    return(value)
   } else if (info$type == "float") {
     return(as.double(value))
   } else if (info$type == "categorical") {

man/covidcast_epidata.Rd

@@ -100,6 +100,29 @@ test_that("parse_data_frame warns when df contains fields not listed in meta", {
   expect_no_warning(parse_data_frame(epidata_call, mock_df))
 })
 
+test_that("parse_data_frame warns when df contains int values with decimal component", {
+  epidata_call <- pub_flusurv(
+    locations = "ca",
+    epiweeks = 202001,
+    fetch_args = fetch_args_list(dry_run = TRUE)
+  )
+  # see generate_test_data.R
+  mock_df <- as.data.frame(readr::read_rds(testthat::test_path("data/flusurv-epiweeks.rds")))
+
+  # Int fields are returned as double
+  result <- parse_data_frame(epidata_call, mock_df)
+  expect_type(result$lag, "double")
+
+  # Replace int fields with decimal
+  mock_df$lag <- 4.3
+
+  # Warning when int values have a decimal component
+  expect_warning(
+    parse_data_frame(epidata_call, mock_df),
+    class = "epidatr__int_nonzero_decimal_digits"
+  )
+})
+
 test_that("parse_api_date accepts str and int input", {
   expect_identical(parse_api_date("20200101"), as.Date("2020-01-01"))
   expect_identical(parse_api_date(20200101), as.Date("2020-01-01"))