Skip to content

Conversation

@JavierMtzRdz
Copy link
Contributor

@JavierMtzRdz JavierMtzRdz commented Nov 4, 2025

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current epidatr main reviewers:
    brookslogan, dshemetov, nmdefries, dsweber2.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).

Change explanations for reviewer

  • Change: Provide a clearer explanation as in the message linked to the function.
  • Change: Provides a clearer explanation.
  • Change: Adds a .epidatr_shared_params list of parameters that includes shared parameters and inherits shared parameters in the specific functions' documentation.
  • Change: Adds a Data Versioning section to clarify its use.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

JavierMtzRdz and others added 8 commits November 2, 2025 15:01
It clarifies that the API key needs to be manually updated and closes issue 295.
This closes issue 287 since the location does not need to be specified.
…Versioning section

To reduce repetition, epidatr_shared_params contains shared parameters that are inherited by the functions’ documentation. Data Versioning is also inherited where necessary.
This change prevents issues with referencing .epidatr_shared_params when building the documentation site.
@JavierMtzRdz
Copy link
Contributor Author

JavierMtzRdz commented Nov 7, 2025

I added changes to address issues #208 and #288.

Change explanations for reviewer

  • Change: I added conditional examples with @examplesIf so they only run when there is internet access and the corresponding API key is available. I did not use \donttest as it is checked by CRAN occasionally. The examples on the documentation website appear when the API key is available. Examples with lengthy outputs are enclosed within \dontrun safeguards.
  • Note: All examples worked. The only relevant comment is that the pub_flusurv example returns data with a warning.

Warning message:
Not all return columns are specified as expected epidata fields
ℹ Unspecified fields season, rate_age_5, rate_age_6, rate_age_7, rate_age_18t29,
rate_age_30t39, rate_age_40t49, rate_age_5t11, rate_age_12t17, rate_age_lt18,
rate_age_gte18, rate_age_1t4, rate_age_gte75, rate_age_0tlt1, rate_race_white,
rate_race_black, rate_race_hisp, rate_race_asian, …, rate_flu_a, and rate_flu_b may
need to be manually converted to more appropriate classes

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@dshemetov
Copy link
Contributor

dshemetov commented Nov 8, 2025

Request: the Data Versioning section is good, but can we also add two more examples to the Getting Started vignette to address my suggestion in #199? Specifically of using the issues field and the lag field.

…“Getting Started” vignette and add references to the versioned data vignette in the versioned data documentation section.
@JavierMtzRdz
Copy link
Contributor Author

In the last commit, I included examples using the issues and lag arguments in the “Getting Started” vignette and added references to the versioned data vignette in the versioned data documentation section.

Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I made some small changes to the shared params wording, and updated DESCRIPTION and NEWS.

The examples are now failing, although I didn't change them. Potentially a dependency bump?

@JavierMtzRdz
Copy link
Contributor Author

There was an example missing a function namespace. It has been fixed.

@JavierMtzRdz JavierMtzRdz merged commit d653d1f into dev Dec 1, 2025
8 checks passed
@JavierMtzRdz JavierMtzRdz deleted the adj-doc-issue branch December 1, 2025 19:36
@JavierMtzRdz JavierMtzRdz restored the adj-doc-issue branch December 1, 2025 19:38
@nmdefries nmdefries deleted the adj-doc-issue branch December 1, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants