-
Notifications
You must be signed in to change notification settings - Fork 5
docs: Adds details to attend issues #295, #287, #221, #199 #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It clarifies that the API key needs to be manually updated and closes issue 295.
This closes issue 287 since the location does not need to be specified.
…Versioning section To reduce repetition, epidatr_shared_params contains shared parameters that are inherited by the functions’ documentation. Data Versioning is also inherited where necessary.
This change prevents issues with referencing .epidatr_shared_params when building the documentation site.
This closes essue #287.
|
I added changes to address issues #208 and #288. Change explanations for reviewer
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch |
|
Request: the Data Versioning section is good, but can we also add two more examples to the Getting Started vignette to address my suggestion in #199? Specifically of using the issues field and the lag field. |
…“Getting Started” vignette and add references to the versioned data vignette in the versioned data documentation section.
|
In the last commit, I included examples using the issues and lag arguments in the “Getting Started” vignette and added references to the versioned data vignette in the versioned data documentation section. |
nmdefries
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I made some small changes to the shared params wording, and updated DESCRIPTION and NEWS.
The examples are now failing, although I didn't change them. Potentially a dependency bump?
|
There was an example missing a function namespace. It has been fixed. |
Checklist
Please:
PR).
brookslogan, dshemetov, nmdefries, dsweber2.
DESCRIPTION. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
Change explanations for reviewer
save_api_keyis inaccurate.pvt_meta_norostatlocationsparameter lacks valid inputs.as_of,issues, andlagMagic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch