Skip to content

Conversation

@dshemetov
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current epidatr main reviewers:
    brookslogan, dshemetov, nmdefries, dsweber2.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).

Change explanations for reviewer

Seems like a footgun to cache *_meta endpoints outputs, so I made them not do that by default.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@dshemetov
Copy link
Contributor Author

Ugh nvm meta endpoints aren't "cachable" already, I jumped the gun

@dshemetov dshemetov closed this Nov 20, 2025
@dshemetov dshemetov deleted the ds/meta-no-cache branch November 20, 2025 21:05
@melange396
Copy link
Contributor

endpoint covidcast_meta/ (but not endpoint covidcast/meta/) has cache enabled. iirc, it was enabled so that an r package of ours (perhaps this one?) would pass checks in CRAN; without the cache, it would get rate limited and fail.

@dshemetov
Copy link
Contributor Author

This PR was about epidatr's user-local cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants